content/common/gpu/media/v4l2_video_device.cc - Issue 430583005: Make VEA test support videos with different coded size and visible size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_device.cc

Issue 430583005: Make VEA test support videos with different coded size and visible size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Copy data line by line Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('j') | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_video_device.cc

diff --git a/content/common/gpu/media/v4l2_video_device.cc b/content/common/gpu/media/v4l2_video_device.cc

index 0a094ba6e47d143bb36b7b602094cfb4d73fff44..7adc31d754bcc78f8f468ae35ae84c49f7dc85c7 100644

--- a/content/common/gpu/media/v4l2_video_device.cc

+++ b/content/common/gpu/media/v4l2_video_device.cc

@@ -131,7 +131,7 @@ gfx::Size V4L2Device::CodedSizeFromV4L2Format(struct v4l2_format format) {

if (V4L2_TYPE_IS_MULTIPLANAR(format.type)) {

for (size_t i = 0; i < format.fmt.pix_mp.num_planes; ++i) {

- DCHECK_EQ(format.fmt.pix_mp.plane_fmt[i].bytesperline,

+ DCHECK_LE(format.fmt.pix_mp.plane_fmt[i].bytesperline,

wuchengli 2014/08/26 09:20:53 Remove. This is a kernel bug.

henryhsu 2014/08/27 02:59:05 Done.

base::checked_cast<__u32>(media::VideoFrame::RowBytes(

i, frame_format, coded_size.width())));

}