Make VEA test support videos with different coded size and visible size

base/files/memory_mapped_file_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/memory_mapped_file.h"
 
 #include "base/files/file_path.h"
 #include "base/strings/string16.h"
 #include "base/threading/thread_restrictions.h"
 
 namespace base {
 
 MemoryMappedFile::MemoryMappedFile() : data_(NULL), length_(0), image_(false) {
 }
 
 bool MemoryMappedFile::InitializeAsImageSection(const FilePath& file_name) {
   image_ = true;
   return Initialize(file_name);
 }
 
 bool MemoryMappedFile::MapFileRegionToMemory(
-    const MemoryMappedFile::Region& region) {
+    const MemoryMappedFile::Region& region, bool write) {
   ThreadRestrictions::AssertIOAllowed();
 
   if (!file_.IsValid())
     return false;
 
-  int flags = image_ ? SEC_IMAGE | PAGE_READONLY : PAGE_READONLY;
+  int flags = 0;
+  if (image_)
+    flags = SEC_IMAGE | PAGE_READONLY;
+  else
+    flags = write ? PAGE_READWRITE : PAGE_READONLY;

[wuchengli, 2014/09/01 09:19:25]

You forgot to address this comment?

From MSDN, it doesn't say SEC_IMAGE is not allowed with PAGE_READWRITE. I think
the code should be like this.
int flags = write ? PAGE_READWRITE : PAGE_READONLY;
if (image_) flags |= SEC_IMAGE;

 
   file_mapping_.Set(::CreateFileMapping(file_.GetPlatformFile(), NULL,
                                         flags, 0, 0, NULL));
   if (!file_mapping_.IsValid())
     return false;
 
   LARGE_INTEGER map_start = {0};
   SIZE_T map_size = 0;
   int32 data_offset = 0;
 
@@ skipping 20 matching lines @@
     if (aligned_start < 0 || size < 0 ||
         static_cast<uint64>(size) > std::numeric_limits<SIZE_T>::max()) {
       DLOG(ERROR) << "Region bounds are not valid for MapViewOfFile";
       return false;
     }
     map_start.QuadPart = aligned_start;
     map_size = static_cast<SIZE_T>(size);
     length_ = static_cast<size_t>(region.size);
   }
 
+  int map_access = write ? FILE_MAP_WRITE : FILE_MAP_READ;
   data_ = static_cast<uint8*>(::MapViewOfFile(file_mapping_.Get(),
-                                              FILE_MAP_READ,
+                                              map_access,
                                               map_start.HighPart,
                                               map_start.LowPart,
                                               map_size));
   if (data_ == NULL)
     return false;
   data_ += data_offset;
   return true;
 }
 
 void MemoryMappedFile::CloseHandles() {
   if (data_)
     ::UnmapViewOfFile(data_);
   if (file_mapping_.IsValid())
     file_mapping_.Close();
   if (file_.IsValid())
     file_.Close();
 
   data_ = NULL;
   length_ = 0;
 }
 
 }  // namespace base