Make VEA test support videos with different coded size and visible size

content/common/gpu/media/video_encode_accelerator_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 15 matching lines @@
 #endif
 
 #if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
 #include "content/common/gpu/media/v4l2_video_encode_accelerator.h"
 #elif defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY) && defined(USE_X11)
 #include "content/common/gpu/media/vaapi_video_encode_accelerator.h"
 #else
 #error The VideoEncodeAcceleratorUnittest is not supported on this platform.
 #endif
 
+#define ALIGN_64_BYTES(x) (((x) + 63) & ~63)
+
 using media::VideoEncodeAccelerator;
 
 namespace content {
 namespace {
 
 const media::VideoFrame::Format kInputFormat = media::VideoFrame::I420;
 
 // Arbitrarily chosen to add some depth to the pipeline.
 const unsigned int kNumOutputBuffers = 4;
 const unsigned int kNumExtraInputFrames = 4;
@@ skipping 50 matching lines @@
 
 struct TestStream {
   TestStream()
       : requested_bitrate(0),
         requested_framerate(0),
         requested_subsequent_bitrate(0),
         requested_subsequent_framerate(0) {}
   ~TestStream() {}
 
   gfx::Size size;
+  std::string in_filename;
   base::MemoryMappedFile input_file;
   media::VideoCodecProfile requested_profile;
   std::string out_filename;
   unsigned int requested_bitrate;
   unsigned int requested_framerate;
   unsigned int requested_subsequent_bitrate;
   unsigned int requested_subsequent_framerate;
 };
 
+// ARM performs CPU cache management with CPU cache line granularity. We thus
+// need to ensure our buffers are CPU cache line-aligned (64 byte-aligned).
+// Otherwise newer kernels will refuse to accept them, and on older kernels
+// we'll be treating ourselves to random corruption.
+// Since we are just mmapping and passing chunks of the input file, to ensure
+// alignment, if the starting virtual addresses of YUV planes of the frames
+// in it were not 64 byte-aligned, we'd have to use a separate set of input

[wuchengli, 2014/08/28 08:33:00]

Please remove "use a separate set of input buffers and copy the frames". Just
explain how you achieve the alignment now.

[henryhsu, 2014/08/28 09:36:45]

Done.

+// buffers and copy the frames into them before sending to the encoder.
+// Now we test resolutions different from coded size and prepare chunks before
+// testing to avoid performance impact.

[wuchengli, 2014/08/28 08:33:01]

s/testing/encoding/

[henryhsu, 2014/08/28 09:36:44]

Done.

+// Use |coded_size| to copy YUV data into memory from |test_stream| input file.
+// The copyied result will be saved in test_stream->input_file.

[wuchengli, 2014/08/28 08:33:01]

s/copyied/copied/

[henryhsu, 2014/08/28 09:36:45]

Done.

+// Also calculate the byte size of an input frame and set it to
+// |input_buffer_size|.
+static void PrepareInputMemory(const gfx::Size& coded_size,
+                               TestStream* test_stream,

[wuchengli, 2014/08/28 08:33:01]

It is clearer to pass test_stream->size, test_stream->input_file, and
test_stream->in_filename to the function parameters.

[henryhsu, 2014/08/28 09:36:44]

Done.

+                               size_t* input_buffer_size) {
+  base::FilePath temp_file;
+  size_t input_num_planes = media::VideoFrame::NumPlanes(kInputFormat);
+  std::vector<size_t> padding_sizes(input_num_planes);
+  std::vector<size_t> coded_bpl(input_num_planes);
+  std::vector<size_t> visible_bpl(input_num_planes);
+  std::vector<size_t> visible_plane_rows(input_num_planes);
+  size_t visible_frame_size =

[wuchengli, 2014/08/28 08:33:01]

I think it's easier to understand to s/visible_frame_size/visible_buffer_size/
and s/input_buffer_size/coded_buffer_size/.

[henryhsu, 2014/08/28 09:36:45]

Done.

+      media::VideoFrame::AllocationSize(kInputFormat, test_stream->size);
+
+  // YUV plane starting address should be 64 bytes alignment.
+  // Calculate padding size for each plane, and frame size for visible size

[wuchengli, 2014/08/28 08:33:00]

s/frame size/frame allocation size/. Remove visible size because it's not
calculated here. Update the comment. This loop calculates other stuff, too.

[henryhsu, 2014/08/28 09:36:44]

Done.

+  // and coded size.
+  *input_buffer_size = 0;
+  for (off_t i = 0; i < input_num_planes; i++) {
+    size_t size =
+        media::VideoFrame::PlaneAllocationSize(kInputFormat, i, coded_size);
+    size_t padding_bytes = ALIGN_64_BYTES(size) - size;
+
+    coded_bpl[i] =
+        media::VideoFrame::RowBytes(i, kInputFormat, coded_size.width());
+    visible_bpl[i] =
+        media::VideoFrame::RowBytes(i, kInputFormat, test_stream->size.width());
+    visible_plane_rows[i] =
+        media::VideoFrame::Rows(i, kInputFormat, test_stream->size.height());
+    size_t padding_rows =
+        media::VideoFrame::Rows(i, kInputFormat, coded_size.height()) -
+        visible_plane_rows[i];
+    padding_sizes[i] = padding_rows * coded_bpl[i] + padding_bytes;
+    *input_buffer_size += ALIGN_64_BYTES(size);
+  }
+
+  // Test case may have many encoders and memory should be prepared once.
+  if (test_stream->input_file.IsValid())
+    return;
+
+  base::MemoryMappedFile input_file;
+  CHECK(base::CreateTemporaryFile(&temp_file));
+  CHECK(input_file.Initialize(base::FilePath(test_stream->in_filename)));
+
+  size_t num_frames = input_file.length() / visible_frame_size;
+  uint32 flags = base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE |
+                 base::File::FLAG_READ;
+
+  // Create a temporary file with coded_size length.
+  base::File file(base::FilePath(temp_file), flags);
+  file.Write(*input_buffer_size * num_frames - 1, ".", 1);
+  CHECK(test_stream->input_file.Initialize(file.Pass()));
+
+#if defined(ARCH_CPU_ARMEL)
+  // Assert that the frame size is a multiple of 64 bytes. This ensures all
+  // frames start at 64-byte boundary, because MemoryMappedFile should be
+  // mmap()ed at virtual page start as well.
+  ASSERT_EQ(*input_buffer_size & 63, 0u)

[wuchengli, 2014/08/28 08:33:01]

This can be removed. The above for loop ensured it.

[henryhsu, 2014/08/28 09:36:44]

Done.

+      << "Frame size has to be a multiple of 64 bytes";
+  ASSERT_EQ(reinterpret_cast<off_t>(test_stream->input_file.data()) & 63, 0)

[wuchengli, 2014/08/28 08:33:01]

This can be removed. The first time of ASSERT_EQ below ensures it.

[henryhsu, 2014/08/28 09:36:44]

Done.

+      << "Mapped file should be mapped at a 64 byte boundary";
+#endif
+
+  off_t src_offset = 0, dest_offset = 0;
+  while (src_offset < static_cast<off_t>(input_file.length())) {
+    for (off_t i = 0; i < input_num_planes; i++) {
+#if defined(ARCH_CPU_ARMEL)
+      // Assert that each plane of frame starts at 64-byte boundary.
+      uint8* ptr =
+          const_cast<uint8*>(test_stream->input_file.data() + dest_offset);
+      ASSERT_EQ(reinterpret_cast<off_t>(ptr) & 63, 0)
+          << "Planes of frame should be mapped at a 64 byte boundary";
+#endif
+      for (off_t j = 0; j < visible_plane_rows[i]; j++) {
+        uint8* src = const_cast<uint8*>(input_file.data() + src_offset);

[wuchengli, 2014/08/28 08:33:01]

nit: |src| can be const and the casting can be removed.

[henryhsu, 2014/08/28 09:36:45]

Done.

+        uint8* dest =
+            const_cast<uint8*>(test_stream->input_file.data() + dest_offset);
+        memcpy(dest, src, visible_bpl[i]);
+        src_offset += visible_bpl[i];
+        dest_offset += coded_bpl[i];
+      }
+      dest_offset += padding_sizes[i];
+    }
+  }
+  base::DeleteFile(temp_file, false);

[wuchengli, 2014/08/28 08:33:00]

Can we delete the file and still access it from test_stream->input_file?

[henryhsu, 2014/08/28 09:36:44]

Yes, I tried this and encoded results are correct.

[wuchengli, 2014/08/28 10:17:48]

This doesn't make sense. Why we can access the mapped file after it is removed?

[henryhsu, 2014/08/29 06:36:40]

Not sure. But for safety, we can rollback to original way to delete file after
test finished.

+}
+
 // Parse |data| into its constituent parts, set the various output fields
 // accordingly, read in video stream, and store them to |test_streams|.
 static void ParseAndReadTestStreamData(const base::FilePath::StringType& data,
                                        ScopedVector<TestStream>* test_streams) {
   // Split the string to individual test stream data.
   std::vector<base::FilePath::StringType> test_streams_data;
   base::SplitString(data, ';', &test_streams_data);
   CHECK_GE(test_streams_data.size(), 1U) << data;
 
   // Parse each test stream data and read the input file.
   for (size_t index = 0; index < test_streams_data.size(); ++index) {
     std::vector<base::FilePath::StringType> fields;
     base::SplitString(test_streams_data[index], ':', &fields);
     CHECK_GE(fields.size(), 4U) << data;
     CHECK_LE(fields.size(), 9U) << data;
     TestStream* test_stream = new TestStream();
 
-    base::FilePath::StringType filename = fields[0];
+    test_stream->in_filename = fields[0];
     int width, height;
     CHECK(base::StringToInt(fields[1], &width));
     CHECK(base::StringToInt(fields[2], &height));
     test_stream->size = gfx::Size(width, height);
     CHECK(!test_stream->size.IsEmpty());
     int profile;
     CHECK(base::StringToInt(fields[3], &profile));
     CHECK_GT(profile, media::VIDEO_CODEC_PROFILE_UNKNOWN);
     CHECK_LE(profile, media::VIDEO_CODEC_PROFILE_MAX);
     test_stream->requested_profile =
@@ skipping 11 matching lines @@
     if (fields.size() >= 8 && !fields[7].empty()) {
       CHECK(base::StringToUint(fields[7],
                                &test_stream->requested_subsequent_bitrate));
     }
 
     if (fields.size() >= 9 && !fields[8].empty()) {
       CHECK(base::StringToUint(fields[8],
                                &test_stream->requested_subsequent_framerate));
     }
 
-    CHECK(test_stream->input_file.Initialize(base::FilePath(filename)));
     test_streams->push_back(test_stream);
   }
 }
 
 // Set default parameters of |test_streams| and update the parameters according
 // to |mid_stream_bitrate_switch| and |mid_stream_framerate_switch|.
 static void UpdateTestStreamData(bool mid_stream_bitrate_switch,
                                  bool mid_stream_framerate_switch,
                                  ScopedVector<TestStream>* test_streams) {
   for (size_t i = 0; i < test_streams->size(); i++) {
@@ skipping 370 matching lines @@
   CHECK(validator_.get());
 
   if (save_to_file_) {
     CHECK(!test_stream_.out_filename.empty());
     base::FilePath out_filename(test_stream_.out_filename);
     // This creates or truncates out_filename.
     // Without it, AppendToFile() will not work.
     EXPECT_EQ(0, base::WriteFile(out_filename, NULL, 0));
   }
 
-  input_buffer_size_ =
-      media::VideoFrame::AllocationSize(kInputFormat, test_stream.size);
-  CHECK_GT(input_buffer_size_, 0UL);
-
-  // Calculate the number of frames in the input stream by dividing its length
-  // in bytes by frame size in bytes.
-  CHECK_EQ(test_stream_.input_file.length() % input_buffer_size_, 0U)
-      << "Stream byte size is not a product of calculated frame byte size";
-  num_frames_in_stream_ = test_stream_.input_file.length() / input_buffer_size_;
-  CHECK_GT(num_frames_in_stream_, 0UL);
-  CHECK_LE(num_frames_in_stream_, kMaxFrameNum);
-
-  // We may need to loop over the stream more than once if more frames than
-  // provided is required for bitrate tests.
-  if (force_bitrate_ && num_frames_in_stream_ < kMinFramesForBitrateTests) {
-    DVLOG(1) << "Stream too short for bitrate test (" << num_frames_in_stream_
-             << " frames), will loop it to reach " << kMinFramesForBitrateTests
-             << " frames";
-    num_frames_to_encode_ = kMinFramesForBitrateTests;
-  } else {
-    num_frames_to_encode_ = num_frames_in_stream_;
-  }
-
   thread_checker_.DetachFromThread();
 }
 
 VEAClient::~VEAClient() { CHECK(!has_encoder()); }
 
 void VEAClient::CreateEncoder() {
   DCHECK(thread_checker_.CalledOnValidThread());
   CHECK(!has_encoder());
 
 #if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
@@ skipping 34 matching lines @@
   return num_encoded_frames_ / duration.InSecondsF();
 }
 
 void VEAClient::RequireBitstreamBuffers(unsigned int input_count,
                                         const gfx::Size& input_coded_size,
                                         size_t output_size) {
   DCHECK(thread_checker_.CalledOnValidThread());
   ASSERT_EQ(state_, CS_INITIALIZED);
   SetState(CS_ENCODING);
 
-  // TODO(posciak): For now we only support input streams that meet encoder
-  // size requirements exactly (i.e. coded size == visible size), so that we
-  // can simply mmap the stream file and feed the encoder directly with chunks
-  // of that, instead of memcpying from mmapped file into a separate set of
-  // input buffers that would meet the coded size and alignment requirements.
-  // If/when this is changed, the ARM-specific alignment check below should be
-  // redone as well.
+  PrepareInputMemory(input_coded_size,

[wuchengli, 2014/08/28 08:33:01]

s/PrepareInputMemory/PrepareInputBuffers/ to be consistent with
|input_buffer_size_|.

[henryhsu, 2014/08/28 09:36:44]

Done.

+                     const_cast<TestStream*>(&test_stream_),
+                     &input_buffer_size_);
+  CHECK_GT(input_buffer_size_, 0UL);
+
+  // Calculate the number of frames in the input stream by dividing its length
+  // in bytes by frame size in bytes.
+  CHECK_EQ(test_stream_.input_file.length() % input_buffer_size_, 0U)
+      << "Stream byte size is not a product of calculated frame byte size";
+  num_frames_in_stream_ = test_stream_.input_file.length() / input_buffer_size_;
+  CHECK_GT(num_frames_in_stream_, 0UL);
+  CHECK_LE(num_frames_in_stream_, kMaxFrameNum);
+
+  // We may need to loop over the stream more than once if more frames than
+  // provided is required for bitrate tests.
+  if (force_bitrate_ && num_frames_in_stream_ < kMinFramesForBitrateTests) {
+    DVLOG(1) << "Stream too short for bitrate test (" << num_frames_in_stream_
+             << " frames), will loop it to reach " << kMinFramesForBitrateTests
+             << " frames";
+    num_frames_to_encode_ = kMinFramesForBitrateTests;
+  } else {
+    num_frames_to_encode_ = num_frames_in_stream_;
+  }
+
   input_coded_size_ = input_coded_size;
-  ASSERT_EQ(input_coded_size_, test_stream_.size);
-#if defined(ARCH_CPU_ARMEL)
-  // ARM performs CPU cache management with CPU cache line granularity. We thus
-  // need to ensure our buffers are CPU cache line-aligned (64 byte-aligned).
-  // Otherwise newer kernels will refuse to accept them, and on older kernels
-  // we'll be treating ourselves to random corruption.
-  // Since we are just mmapping and passing chunks of the input file, to ensure
-  // alignment, if the starting virtual addresses of the frames in it were not
-  // 64 byte-aligned, we'd have to use a separate set of input buffers and copy
-  // the frames into them before sending to the encoder. It would have been an
-  // overkill here though, because, for now at least, we only test resolutions
-  // that result in proper alignment, and it would have also interfered with
-  // performance testing. So just assert that the frame size is a multiple of
-  // 64 bytes. This ensures all frames start at 64-byte boundary, because
-  // MemoryMappedFile should be mmapp()ed at virtual page start as well.
-  ASSERT_EQ(input_buffer_size_ & 63, 0u)
-      << "Frame size has to be a multiple of 64 bytes";
-  ASSERT_EQ(reinterpret_cast<off_t>(test_stream_.input_file.data()) & 63, 0)
-      << "Mapped file should be mapped at a 64 byte boundary";
-#endif
-
   num_required_input_buffers_ = input_count;
   ASSERT_GT(num_required_input_buffers_, 0UL);
 
   output_buffer_size_ = output_size;
   ASSERT_GT(output_buffer_size_, 0UL);
 
   for (unsigned int i = 0; i < kNumOutputBuffers; ++i) {
     base::SharedMemory* shm = new base::SharedMemory();
     CHECK(shm->CreateAndMapAnonymous(output_buffer_size_));
     output_shms_.push_back(shm);
@@ skipping 65 matching lines @@
 void VEAClient::InputNoLongerNeededCallback(int32 input_id) {
   std::set<int32>::iterator it = inputs_at_client_.find(input_id);
   ASSERT_NE(it, inputs_at_client_.end());
   inputs_at_client_.erase(it);
   FeedEncoderWithInputs();
 }
 
 scoped_refptr<media::VideoFrame> VEAClient::PrepareInputFrame(off_t position) {
   CHECK_LE(position + input_buffer_size_, test_stream_.input_file.length());
 
-  uint8* frame_data =
+  uint8* frame_data_y =
       const_cast<uint8*>(test_stream_.input_file.data() + position);
+  uint8* frame_data_u =
+      frame_data_y + ALIGN_64_BYTES(media::VideoFrame::PlaneAllocationSize(
+                         kInputFormat, 0, input_coded_size_));
+  uint8* frame_data_v =
+      frame_data_u + ALIGN_64_BYTES(media::VideoFrame::PlaneAllocationSize(
+                         kInputFormat, 1, input_coded_size_));
 
   CHECK_GT(current_framerate_, 0U);
   scoped_refptr<media::VideoFrame> frame =
       media::VideoFrame::WrapExternalYuvData(
           kInputFormat,
           input_coded_size_,
           gfx::Rect(test_stream_.size),
           test_stream_.size,
           input_coded_size_.width(),
           input_coded_size_.width() / 2,
           input_coded_size_.width() / 2,
-          frame_data,
-          frame_data + input_coded_size_.GetArea(),
-          frame_data + (input_coded_size_.GetArea() * 5 / 4),
+          frame_data_y,
+          frame_data_u,
+          frame_data_v,
           base::TimeDelta().FromMilliseconds(
               next_input_id_ * base::Time::kMillisecondsPerSecond /
               current_framerate_),
           media::BindToCurrentLoop(
               base::Bind(&VEAClient::InputNoLongerNeededCallback,
                          base::Unretained(this),
                          next_input_id_)));
 
   CHECK(inputs_at_client_.insert(next_input_id_).second);
   ++next_input_id_;
@@ skipping 282 matching lines @@
       test_stream_data->assign(it->second.c_str());
       continue;
     }
     if (it->first == "v" || it->first == "vmodule")
       continue;
     LOG(FATAL) << "Unexpected switch: " << it->first << ":" << it->second;
   }
 
   return RUN_ALL_TESTS();
 }