Make VEA test support videos with different coded size and visible size

base/files/memory_mapped_file.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/memory_mapped_file.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/sys_info.h"
 
@@ skipping 13 matching lines @@
 
 bool MemoryMappedFile::Region::operator==(
     const MemoryMappedFile::Region& other) const {
   return other.offset == offset && other.size == size;
 }
 
 MemoryMappedFile::~MemoryMappedFile() {
   CloseHandles();
 }
 
 bool MemoryMappedFile::Initialize(const FilePath& file_name) {

[rvargas (doing something else), 2014/08/26 21:25:21]

This method documentation states that "access is restricted to read-only".

If we want to add write access, that should be explicit through the API so that
callers decide what to do. Also, the protections of the mapped section should
match the requested file access (unless you are not trying to write to the
section, in which case base doesn't have to change).

[henryhsu, 2014/08/27 02:59:06]

Done.

   if (IsValid())
     return false;
 
-  file_.Initialize(file_name, File::FLAG_OPEN | File::FLAG_READ);
+  file_.Initialize(file_name, File::FLAG_OPEN |
+                              File::FLAG_READ |
+                              File::FLAG_WRITE);
 
   if (!file_.IsValid()) {
     DLOG(ERROR) << "Couldn't open " << file_name.AsUTF8Unsafe();
     return false;
   }
 
   if (!MapFileRegionToMemory(Region::kWholeFile)) {
     CloseHandles();
     return false;
   }
@@ skipping 31 matching lines @@
                                                     int32* offset) {
   // Sadly, on Windows, the mmap alignment is not just equal to the page size.
   const int64 mask = static_cast<int64>(SysInfo::VMAllocationGranularity()) - 1;
   DCHECK_LT(mask, std::numeric_limits<int32>::max());
   *offset = start & mask;
   *aligned_start = start & ~mask;
   *aligned_size = (size + *offset + mask) & ~mask;
 }
 
 }  // namespace base