Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: chrome/browser/sync/glue/device_info_data_type_controller.cc

Issue 430583003: Refactor syncable DEVICE_INFO type from ChangeProcessor to SyncableService - Part 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed memory leak in DataTypeController unit tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/device_info_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/device_info_data_type_controller.cc b/chrome/browser/sync/glue/device_info_data_type_controller.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a8deb06303777c1035f3ea6bd6e2718e1a2f8de6
--- /dev/null
+++ b/chrome/browser/sync/glue/device_info_data_type_controller.cc
@@ -0,0 +1,52 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/sync/glue/device_info_data_type_controller.h"
+
+#include "chrome/browser/sync/glue/chrome_report_unrecoverable_error.h"
+#include "chrome/browser/sync/glue/local_device_info_provider.h"
+#include "content/public/browser/browser_thread.h"
+
+using content::BrowserThread;
+
+namespace browser_sync {
+
+DeviceInfoDataTypeController::DeviceInfoDataTypeController(
+ sync_driver::SyncApiComponentFactory* sync_factory,
+ LocalDeviceInfoProvider* local_device_info_provider,
+ const DisableTypeCallback& disable_callback)
+ : UIDataTypeController(
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
+ base::Bind(&ChromeReportUnrecoverableError),
+ disable_callback,
+ syncer::DEVICE_INFO,
+ sync_factory),
+ local_device_info_provider_(local_device_info_provider) {
+}
+
+DeviceInfoDataTypeController::~DeviceInfoDataTypeController() {
+}
+
+bool DeviceInfoDataTypeController::StartModels() {
+ // Start the data type as soon as the local device info gets available.
+ if (local_device_info_provider_->GetLocalDeviceInfo()) {
+ return true;
+ }
+
+ subscription_ = local_device_info_provider_->RegisterOnInitializedCallback(
+ base::Bind(&DeviceInfoDataTypeController::OnLocalDeviceInfoLoaded, this));
+
+ return false;
+}
+
+void DeviceInfoDataTypeController::OnLocalDeviceInfoLoaded() {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_EQ(state_, MODEL_STARTING);
+ DCHECK(local_device_info_provider_->GetLocalDeviceInfo());
+
+ subscription_.reset();
+ OnModelLoaded();
+}
+
+} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698