Enable system token in platformKeys api.

chrome/browser/chromeos/platform_keys/platform_keys.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_PLATFORM_KEYS_H_
 #define CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_PLATFORM_KEYS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace content {
 class BrowserContext;
 }
 
 namespace net {
 class X509Certificate;
 typedef std::vector<scoped_refptr<X509Certificate> > CertificateList;
 }
 
 namespace chromeos {
 
 namespace platform_keys {
 
+const char kTokenIdUser[] = "user";

[Joao da Silva, 2014/07/30 08:46:38]

Change to "extern const char kTokenIdUser[];" and define it in the .cc file

[Joao da Silva, 2014/07/30 08:46:38]

Also, what are these constants for? Document them here

[pneubeck (no reviews), 2014/07/30 13:53:44]

Done.

[pneubeck (no reviews), 2014/07/30 13:53:44]

Done.

+const char kTokenIdSystem[] = "system";
+
 // Supported hash algorithms.
 enum HashAlgorithm {
   HASH_ALGORITHM_SHA1,
   HASH_ALGORITHM_SHA256,
   HASH_ALGORITHM_SHA384,
   HASH_ALGORITHM_SHA512
 };
 
 namespace subtle {
 // Functions of this namespace shouldn't be called directly from the context of
@@ skipping 69 matching lines @@
 
 // Removes |certificate| from the given token if present. Any intermediate of
 // |certificate| will be ignored. |token_id| is currently ignored, instead the
 // user token associated with |browser_context| is always used. |callback| will
 // be invoked when the removal is finished, possibly with an error message.
 void RemoveCertificate(const std::string& token_id,
                        scoped_refptr<net::X509Certificate> certificate,
                        const RemoveCertificateCallback& callback,
                        content::BrowserContext* browser_context);
 
+// If the list of available tokens could be successfully retrieved, |token_ids|
+// will contain the token ids. If an error, |token_ids| will be NULL and

[Joao da Silva, 2014/07/30 08:46:38]

"If an error" occurs

[pneubeck (no reviews), 2014/07/30 13:53:45]

Done.

+// |error_message| will be set to an/ error message.

[Joao da Silva, 2014/07/30 08:46:38]

remove /

[pneubeck (no reviews), 2014/07/30 13:53:44]

Done.

+typedef base::Callback<void(scoped_ptr<std::vector<std::string> > token_ids,
+                            const std::string& error_message)>
+    GetTokensCallback;
+
+// Gets the list of available tokens.
+void GetTokens(const GetTokensCallback& callback,

[Joao da Silva, 2014/07/30 08:46:38]

Document that this must be called on UI, and |callback| will be called on UI
too.

[pneubeck (no reviews), 2014/07/30 13:53:44]

Done.

+               content::BrowserContext* browser_context);
+
 }  // namespace platform_keys
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_PLATFORM_KEYS_PLATFORM_KEYS_H_