Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(50)

Issue 43054: Stop history search going on beyond the start of history.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by Glen Murphy
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Stop history search going on beyond the start of history. Stop losing first-searches on history page due to BUG=8438, 8456 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11411

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 11

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M chrome/browser/dom_ui/dom_ui_contents.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 1 2 6 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 8 chunks +24 lines, -0 lines 1 comment Download
M chrome/browser/history/history_querying_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/history/visit_database.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/history/visit_database.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/history.html View 7 chunks +21 lines, -10 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)
sky
Mostly just minor stuff. The things that need to be addressed are: . Nuking unused ...
8 years, 6 months ago (2009-03-11 00:10:10 UTC) #1
Glen Murphy
All done. Added code to history_backend to requery for first_time after deletions and fixed swapping ...
8 years, 6 months ago (2009-03-11 00:57:24 UTC) #2
sky
8 years, 6 months ago (2009-03-11 01:11:31 UTC) #3
LGTM

http://codereview.chromium.org/43054/diff/45/49
File chrome/browser/history/history_backend.cc (right):

http://codereview.chromium.org/43054/diff/45/49#newcode1847
Line 1847: first_recorded_time_ = Time::Now();
nuke this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b