Issue 430523002: Fix for constant pool support and debug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430523002: Fix for constant pool support and debug (Closed)

Created:
6 years, 4 months ago by andrew_low

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne, rmcilroy, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix for constant pool support and debug RedirectActivationsToRecompiledCodeOnThread must also patch frame's constant pool. Reference: https://github.com/andrewlow/v8ppc/commit/329d72fd BUG= R=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22701

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/debug.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

andrew_low

Out of line constant pool patch. My PowerPC port uses constant pools and without this ...

6 years, 4 months ago (2014-07-29 18:19:28 UTC) #2

andrew_low

Apologies for churn - still learning the commit / review flow.

6 years, 4 months ago (2014-07-29 19:01:25 UTC) #3

danno

Ross, could you please take a look at this and land it for Andrew?

6 years, 4 months ago (2014-07-30 09:47:01 UTC) #4

rmcilroy

On 2014/07/30 09:47:01, danno wrote: > Ross, could you please take a look at this ...

6 years, 4 months ago (2014-07-30 10:21:42 UTC) #5

rmcilroy

6 years, 4 months ago (2014-07-30 10:32:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r22701 (presubmit successful).