Issue 43052: Fix black titlebar rendering when toggling DWM when the window is maximized:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43052: Fix black titlebar rendering when toggling DWM when the window is maximized:... (Closed)

Created:
11 years, 9 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Fix black titlebar rendering when toggling DWM when the window is maximized: - restore window after hiding it, since our hide hack only works for non-maximized windows - handle WM_WINDOWPOSCHANGING in this case to make sure the window isn't made visible by the restore action http://crbug.com/8526 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11401

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
M	chrome/views/non_client_view.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/views/widget_win.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/views/window.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/views/window.cc	View	1	3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 9 months ago (2009-03-10 23:29:55 UTC) #2

LGTM.  Make sure to tell Mark to merge this in to beta.

http://codereview.chromium.org/43052/diff/1/5
File chrome/views/non_client_view.cc (right):

http://codereview.chromium.org/43052/diff/1/5#newcode69
Line 69: // Important (and ugly) step: restore the window first, since our
hiding hack
Nit: might not want to say "and ugly" since it's not visible to the user...

Expand Messages | Collapse Messages