Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: src/compiler/typer.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/structured-machine-assembler.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index b1c383802c13fbd5b36e4dc525d75cc9dbf60223..3869cac0ffb6a3f0f614f0cc1447ba1b1b82160b 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -97,8 +97,8 @@ class Typer::Visitor : public NullNodeVisitor {
Type* ContextType(Node* node) {
Bounds result =
NodeProperties::GetBounds(NodeProperties::GetContextInput(node));
- ASSERT(result.upper->Is(Type::Internal()));
- ASSERT(result.lower->Equals(result.upper));
+ DCHECK(result.upper->Is(Type::Internal()));
+ DCHECK(result.lower->Equals(result.upper));
return result.upper;
}
@@ -151,7 +151,7 @@ class Typer::NarrowVisitor : public Typer::Visitor {
Bounds previous = NodeProperties::GetBounds(node);
Bounds bounds = TypeNode(node);
NodeProperties::SetBounds(node, Bounds::Both(bounds, previous, zone()));
- ASSERT(bounds.Narrows(previous));
+ DCHECK(bounds.Narrows(previous));
// Stop when nothing changed (but allow reentry in case it does later).
return previous.Narrows(bounds) ? GenericGraphVisit::DEFER
: GenericGraphVisit::REENTER;
@@ -171,8 +171,8 @@ class Typer::WidenVisitor : public Typer::Visitor {
GenericGraphVisit::Control Pre(Node* node) {
Bounds previous = NodeProperties::GetBounds(node);
Bounds bounds = TypeNode(node);
- ASSERT(previous.lower->Is(bounds.lower));
- ASSERT(previous.upper->Is(bounds.upper));
+ DCHECK(previous.lower->Is(bounds.lower));
+ DCHECK(previous.upper->Is(bounds.upper));
NodeProperties::SetBounds(node, bounds); // TODO(rossberg): Either?
// Stop when nothing changed (but allow reentry in case it does later).
return bounds.Narrows(previous) ? GenericGraphVisit::DEFER
@@ -482,8 +482,8 @@ Bounds Typer::Visitor::TypeJSInstanceOf(Node* node) {
Bounds Typer::Visitor::TypeJSLoadContext(Node* node) {
Bounds outer = OperandType(node, 0);
- ASSERT(outer.upper->Is(Type::Internal()));
- ASSERT(outer.lower->Equals(outer.upper));
+ DCHECK(outer.upper->Is(Type::Internal()));
+ DCHECK(outer.lower->Equals(outer.upper));
ContextAccess access = OpParameter<ContextAccess>(node);
Type* context_type = outer.upper;
MaybeHandle<Context> context;
« no previous file with comments | « src/compiler/structured-machine-assembler.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698