Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: src/ast-value-factory.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/cpu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast-value-factory.cc
diff --git a/src/ast-value-factory.cc b/src/ast-value-factory.cc
index cb37902261a7eeb79516b4d7f5ab9c819ef15a23..dcfd289091cb3117e85ee85121e9229df2c7e33e 100644
--- a/src/ast-value-factory.cc
+++ b/src/ast-value-factory.cc
@@ -149,7 +149,7 @@ bool AstValue::IsPropertyName() const {
bool AstValue::BooleanValue() const {
switch (type_) {
case STRING:
- ASSERT(string_ != NULL);
+ DCHECK(string_ != NULL);
return !string_->IsEmpty();
case SYMBOL:
UNREACHABLE();
@@ -179,9 +179,9 @@ bool AstValue::BooleanValue() const {
void AstValue::Internalize(Isolate* isolate) {
switch (type_) {
case STRING:
- ASSERT(string_ != NULL);
+ DCHECK(string_ != NULL);
// Strings are already internalized.
- ASSERT(!string_->string().is_null());
+ DCHECK(!string_->string().is_null());
break;
case SYMBOL:
value_ = Object::GetProperty(
@@ -202,7 +202,7 @@ void AstValue::Internalize(Isolate* isolate) {
}
break;
case STRING_ARRAY: {
- ASSERT(strings_ != NULL);
+ DCHECK(strings_ != NULL);
Factory* factory = isolate->factory();
int len = strings_->length();
Handle<FixedArray> elements = factory->NewFixedArray(len, TENURED);
@@ -210,7 +210,7 @@ void AstValue::Internalize(Isolate* isolate) {
const AstRawString* string = (*strings_)[i];
Handle<Object> element = string->string();
// Strings are already internalized.
- ASSERT(!element.is_null());
+ DCHECK(!element.is_null());
elements->set(i, *element);
}
value_ =
@@ -252,7 +252,7 @@ const AstRawString* AstValueFactory::GetString(Handle<String> literal) {
if (content.IsAscii()) {
return GetOneByteString(content.ToOneByteVector());
}
- ASSERT(content.IsTwoByte());
+ DCHECK(content.IsTwoByte());
return GetTwoByteString(content.ToUC16Vector());
}
@@ -289,7 +289,7 @@ void AstValueFactory::Internalize(Isolate* isolate) {
const AstValue* AstValueFactory::NewString(const AstRawString* string) {
AstValue* value = new (zone_) AstValue(string);
- ASSERT(string != NULL);
+ DCHECK(string != NULL);
if (isolate_) {
value->Internalize(isolate_);
}
« no previous file with comments | « src/ast-value-factory.h ('k') | src/base/cpu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698