Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index eeb091e0eb8b983b04715369b11c81e7ec9ce0d4..92135e169b08fa57119c05091b86a91cd1317580 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -18,7 +18,7 @@ static LChunk* OptimizeGraph(HGraph* graph) {
DisallowHandleAllocation no_handles;
DisallowHandleDereference no_deref;
- ASSERT(graph != NULL);
+ DCHECK(graph != NULL);
BailoutReason bailout_reason = kNoReason;
if (!graph->Optimize(&bailout_reason)) {
FATAL(GetBailoutReason(bailout_reason));
@@ -47,12 +47,12 @@ class CodeStubGraphBuilderBase : public HGraphBuilder {
protected:
virtual HValue* BuildCodeStub() = 0;
HParameter* GetParameter(int parameter) {
- ASSERT(parameter < descriptor_->GetEnvironmentParameterCount());
+ DCHECK(parameter < descriptor_->GetEnvironmentParameterCount());
return parameters_[parameter];
}
HValue* GetArgumentsLength() {
// This is initialized in BuildGraph()
- ASSERT(arguments_length_ != NULL);
+ DCHECK(arguments_length_ != NULL);
return arguments_length_;
}
CompilationInfo* info() { return &info_; }
@@ -139,7 +139,7 @@ bool CodeStubGraphBuilderBase::BuildGraph() {
}
}
- ASSERT(!runtime_stack_params || arguments_length_ != NULL);
+ DCHECK(!runtime_stack_params || arguments_length_ != NULL);
if (!runtime_stack_params) {
stack_parameter_count = graph()->GetConstantMinus1();
arguments_length_ = graph()->GetConstant0();
@@ -261,7 +261,7 @@ static Handle<Code> DoGenerateCode(Stub* stub) {
// the runtime that is significantly faster than using the standard
// stub-failure deopt mechanism.
if (stub->IsUninitialized() && descriptor->has_miss_handler()) {
- ASSERT(!descriptor->stack_parameter_count().is_valid());
+ DCHECK(!descriptor->stack_parameter_count().is_valid());
return stub->GenerateLightweightMissCode();
}
base::ElapsedTimer timer;
@@ -444,7 +444,7 @@ HValue* CodeStubGraphBuilder<FastCloneShallowObjectStub>::BuildCodeStub() {
boilerplate, static_cast<HValue*>(NULL), access));
}
- ASSERT(FLAG_allocation_site_pretenuring || (size == object_size));
+ DCHECK(FLAG_allocation_site_pretenuring || (size == object_size));
if (FLAG_allocation_site_pretenuring) {
BuildCreateAllocationMemento(
object, Add<HConstant>(object_size), allocation_site);
@@ -734,7 +734,7 @@ HValue* CodeStubGraphBuilderBase::BuildArrayNArgumentsConstructor(
checked_length,
fill_mode);
HValue* elements = array_builder->GetElementsLocation();
- ASSERT(elements != NULL);
+ DCHECK(elements != NULL);
// Now populate the elements correctly.
LoopBuilder builder(this,
@@ -868,7 +868,7 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
Type* right_type = state.GetRightType(zone());
Type* result_type = state.GetResultType(zone());
- ASSERT(!left_type->Is(Type::None()) && !right_type->Is(Type::None()) &&
+ DCHECK(!left_type->Is(Type::None()) && !right_type->Is(Type::None()) &&
(state.HasSideEffects() || !result_type->Is(Type::None())));
HValue* result = NULL;
@@ -1178,7 +1178,7 @@ HInstruction* CodeStubGraphBuilderBase::LoadFromOptimizedCodeMap(
int field_offset) {
// By making sure to express these loads in the form [<hvalue> + constant]
// the keyed load can be hoisted.
- ASSERT(field_offset >= 0 && field_offset < SharedFunctionInfo::kEntryLength);
+ DCHECK(field_offset >= 0 && field_offset < SharedFunctionInfo::kEntryLength);
HValue* field_slot = iterator;
if (field_offset > 0) {
HValue* field_offset_value = Add<HConstant>(field_offset);
@@ -1465,7 +1465,7 @@ void CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildElementsKindLimitCheck(
void CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildFastElementLoad(
HGraphBuilder::IfBuilder* if_builder, HValue* receiver, HValue* key,
HValue* instance_type, HValue* bit_field2, ElementsKind kind) {
- ASSERT(!IsExternalArrayElementsKind(kind));
+ DCHECK(!IsExternalArrayElementsKind(kind));
BuildElementsKindLimitCheck(if_builder, bit_field2, kind);
@@ -1489,7 +1489,7 @@ void CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildFastElementLoad(
void CodeStubGraphBuilder<KeyedLoadGenericStub>::BuildExternalElementLoad(
HGraphBuilder::IfBuilder* if_builder, HValue* receiver, HValue* key,
HValue* instance_type, HValue* bit_field2, ElementsKind kind) {
- ASSERT(IsExternalArrayElementsKind(kind));
+ DCHECK(IsExternalArrayElementsKind(kind));
BuildElementsKindLimitCheck(if_builder, bit_field2, kind);
« no previous file with comments | « src/code-stubs.cc ('k') | src/codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698