Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/jsregexp.h

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/json-stringifier.h ('k') | src/jsregexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jsregexp.h
diff --git a/src/jsregexp.h b/src/jsregexp.h
index 4da8ba342c26720fd48d0fe5cc68e55d9e790355..11bad24d4b5ae16d93fca0048317f26b78624062 100644
--- a/src/jsregexp.h
+++ b/src/jsregexp.h
@@ -239,7 +239,7 @@ class CharacterRange {
public:
CharacterRange() : from_(0), to_(0) { }
// For compatibility with the CHECK_OK macro
- CharacterRange(void* null) { ASSERT_EQ(NULL, null); } //NOLINT
+ CharacterRange(void* null) { DCHECK_EQ(NULL, null); } //NOLINT
CharacterRange(uc16 from, uc16 to) : from_(from), to_(to) { }
static void AddClassEscape(uc16 type, ZoneList<CharacterRange>* ranges,
Zone* zone);
@@ -248,7 +248,7 @@ class CharacterRange {
return CharacterRange(value, value);
}
static inline CharacterRange Range(uc16 from, uc16 to) {
- ASSERT(from <= to);
+ DCHECK(from <= to);
return CharacterRange(from, to);
}
static inline CharacterRange Everything() {
@@ -425,12 +425,12 @@ class TextElement V8_FINAL BASE_EMBEDDED {
RegExpTree* tree() const { return tree_; }
RegExpAtom* atom() const {
- ASSERT(text_type() == ATOM);
+ DCHECK(text_type() == ATOM);
return reinterpret_cast<RegExpAtom*>(tree());
}
RegExpCharacterClass* char_class() const {
- ASSERT(text_type() == CHAR_CLASS);
+ DCHECK(text_type() == CHAR_CLASS);
return reinterpret_cast<RegExpCharacterClass*>(tree());
}
@@ -541,8 +541,8 @@ class QuickCheckDetails {
int characters() { return characters_; }
void set_characters(int characters) { characters_ = characters; }
Position* positions(int index) {
- ASSERT(index >= 0);
- ASSERT(index < characters_);
+ DCHECK(index >= 0);
+ DCHECK(index < characters_);
return positions_ + index;
}
uint32_t mask() { return mask_; }
@@ -628,7 +628,7 @@ class RegExpNode: public ZoneObject {
virtual RegExpNode* FilterASCII(int depth, bool ignore_case) { return this; }
// Helper for FilterASCII.
RegExpNode* replacement() {
- ASSERT(info()->replacement_calculated);
+ DCHECK(info()->replacement_calculated);
return replacement_;
}
RegExpNode* set_replacement(RegExpNode* replacement) {
@@ -1445,7 +1445,7 @@ class Trace {
// These set methods and AdvanceCurrentPositionInTrace should be used only on
// new traces - the intention is that traces are immutable after creation.
void add_action(DeferredAction* new_action) {
- ASSERT(new_action->next_ == NULL);
+ DCHECK(new_action->next_ == NULL);
new_action->next_ = actions_;
actions_ = new_action;
}
@@ -1560,7 +1560,7 @@ FOR_EACH_NODE_TYPE(DECLARE_VISIT)
bool has_failed() { return error_message_ != NULL; }
const char* error_message() {
- ASSERT(error_message_ != NULL);
+ DCHECK(error_message_ != NULL);
return error_message_;
}
void fail(const char* error_message) {
« no previous file with comments | « src/json-stringifier.h ('k') | src/jsregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698