Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: src/interface.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interface.h ('k') | src/interpreter-irregexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface.cc
diff --git a/src/interface.cc b/src/interface.cc
index 364de398d2a8005cd91a2fbda883af61591ce4dc..62169f597b16c39f02e02937205310152c42330f 100644
--- a/src/interface.cc
+++ b/src/interface.cc
@@ -10,15 +10,15 @@ namespace v8 {
namespace internal {
Interface* Interface::Lookup(Handle<String> name, Zone* zone) {
- ASSERT(IsModule());
+ DCHECK(IsModule());
ZoneHashMap* map = Chase()->exports_;
if (map == NULL) return NULL;
ZoneAllocationPolicy allocator(zone);
ZoneHashMap::Entry* p = map->Lookup(name.location(), name->Hash(), false,
allocator);
if (p == NULL) return NULL;
- ASSERT(*static_cast<String**>(p->key) == *name);
- ASSERT(p->value != NULL);
+ DCHECK(*static_cast<String**>(p->key) == *name);
+ DCHECK(p->value != NULL);
return static_cast<Interface*>(p->value);
}
@@ -91,8 +91,8 @@ void Interface::DoAdd(const void* name, uint32_t hash, Interface* interface,
void Interface::Unify(Interface* that, Zone* zone, bool* ok) {
if (this->forward_) return this->Chase()->Unify(that, zone, ok);
if (that->forward_) return this->Unify(that->Chase(), zone, ok);
- ASSERT(this->forward_ == NULL);
- ASSERT(that->forward_ == NULL);
+ DCHECK(this->forward_ == NULL);
+ DCHECK(that->forward_ == NULL);
*ok = true;
if (this == that) return;
@@ -138,13 +138,13 @@ void Interface::Unify(Interface* that, Zone* zone, bool* ok) {
void Interface::DoUnify(Interface* that, bool* ok, Zone* zone) {
- ASSERT(this->forward_ == NULL);
- ASSERT(that->forward_ == NULL);
- ASSERT(!this->IsValue());
- ASSERT(!that->IsValue());
- ASSERT(this->index_ == -1);
- ASSERT(that->index_ == -1);
- ASSERT(*ok);
+ DCHECK(this->forward_ == NULL);
+ DCHECK(that->forward_ == NULL);
+ DCHECK(!this->IsValue());
+ DCHECK(!that->IsValue());
+ DCHECK(this->index_ == -1);
+ DCHECK(that->index_ == -1);
+ DCHECK(*ok);
#ifdef DEBUG
Nesting nested;
« no previous file with comments | « src/interface.h ('k') | src/interpreter-irregexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698