Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: src/handles.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/handles.cc
diff --git a/src/handles.cc b/src/handles.cc
index f701d26f05fad265632ab2f203b15d4bfb597d52..d9b130f3cac3d0d25dfd8072e347e4e5614fa1e7 100644
--- a/src/handles.cc
+++ b/src/handles.cc
@@ -24,7 +24,7 @@ Object** HandleScope::Extend(Isolate* isolate) {
Object** result = current->next;
- ASSERT(result == current->limit);
+ DCHECK(result == current->limit);
// Make sure there's at least one scope on the stack and that the
// top of the scope stack isn't a barrier.
if (!Utils::ApiCheck(current->level != 0,
@@ -39,7 +39,7 @@ Object** HandleScope::Extend(Isolate* isolate) {
Object** limit = &impl->blocks()->last()[kHandleBlockSize];
if (current->limit != limit) {
current->limit = limit;
- ASSERT(limit - current->next < kHandleBlockSize);
+ DCHECK(limit - current->next < kHandleBlockSize);
}
}
@@ -66,7 +66,7 @@ void HandleScope::DeleteExtensions(Isolate* isolate) {
#ifdef ENABLE_HANDLE_ZAPPING
void HandleScope::ZapRange(Object** start, Object** end) {
- ASSERT(end - start <= kHandleBlockSize);
+ DCHECK(end - start <= kHandleBlockSize);
for (Object** p = start; p != end; p++) {
*reinterpret_cast<Address*>(p) = v8::internal::kHandleZapValue;
}
@@ -95,7 +95,7 @@ DeferredHandleScope::DeferredHandleScope(Isolate* isolate)
HandleScopeData* data = impl_->isolate()->handle_scope_data();
Object** new_next = impl_->GetSpareOrNewBlock();
Object** new_limit = &new_next[kHandleBlockSize];
- ASSERT(data->limit == &impl_->blocks()->last()[kHandleBlockSize]);
+ DCHECK(data->limit == &impl_->blocks()->last()[kHandleBlockSize]);
impl_->blocks()->Add(new_next);
#ifdef DEBUG
@@ -111,8 +111,8 @@ DeferredHandleScope::DeferredHandleScope(Isolate* isolate)
DeferredHandleScope::~DeferredHandleScope() {
impl_->isolate()->handle_scope_data()->level--;
- ASSERT(handles_detached_);
- ASSERT(impl_->isolate()->handle_scope_data()->level == prev_level_);
+ DCHECK(handles_detached_);
+ DCHECK(impl_->isolate()->handle_scope_data()->level == prev_level_);
}
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698