Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: src/base/platform/platform-posix.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/platform/platform-openbsd.cc ('k') | src/base/platform/platform-qnx.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/platform/platform-posix.cc
diff --git a/src/base/platform/platform-posix.cc b/src/base/platform/platform-posix.cc
index b63163146d9bbf88450cf387a209dcebd555bcaa..6764cf78e0e9acae8953c58ead6e0cb50213a085 100644
--- a/src/base/platform/platform-posix.cc
+++ b/src/base/platform/platform-posix.cc
@@ -169,7 +169,7 @@ void OS::Free(void* address, const size_t size) {
// TODO(1240712): munmap has a return value which is ignored here.
int result = munmap(address, size);
USE(result);
- ASSERT(result == 0);
+ DCHECK(result == 0);
}
@@ -357,12 +357,12 @@ TimezoneCache* OS::CreateTimezoneCache() {
void OS::DisposeTimezoneCache(TimezoneCache* cache) {
- ASSERT(cache == NULL);
+ DCHECK(cache == NULL);
}
void OS::ClearTimezoneCache(TimezoneCache* cache) {
- ASSERT(cache == NULL);
+ DCHECK(cache == NULL);
}
@@ -561,7 +561,7 @@ static void* ThreadEntry(void* arg) {
// one).
{ LockGuard<Mutex> lock_guard(&thread->data()->thread_creation_mutex_); }
SetThreadName(thread->name());
- ASSERT(thread->data()->thread_ != kNoThread);
+ DCHECK(thread->data()->thread_ != kNoThread);
thread->NotifyStartedAndRun();
return NULL;
}
@@ -578,22 +578,22 @@ void Thread::Start() {
pthread_attr_t attr;
memset(&attr, 0, sizeof(attr));
result = pthread_attr_init(&attr);
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
// Native client uses default stack size.
#if !V8_OS_NACL
if (stack_size_ > 0) {
result = pthread_attr_setstacksize(&attr, static_cast<size_t>(stack_size_));
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
}
#endif
{
LockGuard<Mutex> lock_guard(&data_->thread_creation_mutex_);
result = pthread_create(&data_->thread_, &attr, ThreadEntry, this);
}
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
result = pthread_attr_destroy(&attr);
- ASSERT_EQ(0, result);
- ASSERT(data_->thread_ != kNoThread);
+ DCHECK_EQ(0, result);
+ DCHECK(data_->thread_ != kNoThread);
USE(result);
}
@@ -605,7 +605,7 @@ void Thread::Join() {
void Thread::YieldCPU() {
int result = sched_yield();
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
USE(result);
}
@@ -701,7 +701,7 @@ Thread::LocalStorageKey Thread::CreateThreadLocalKey() {
#endif
pthread_key_t key;
int result = pthread_key_create(&key, NULL);
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
USE(result);
LocalStorageKey local_key = PthreadKeyToLocalKey(key);
#ifdef V8_FAST_TLS_SUPPORTED
@@ -715,7 +715,7 @@ Thread::LocalStorageKey Thread::CreateThreadLocalKey() {
void Thread::DeleteThreadLocalKey(LocalStorageKey key) {
pthread_key_t pthread_key = LocalKeyToPthreadKey(key);
int result = pthread_key_delete(pthread_key);
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
USE(result);
}
@@ -729,7 +729,7 @@ void* Thread::GetThreadLocal(LocalStorageKey key) {
void Thread::SetThreadLocal(LocalStorageKey key, void* value) {
pthread_key_t pthread_key = LocalKeyToPthreadKey(key);
int result = pthread_setspecific(pthread_key, value);
- ASSERT_EQ(0, result);
+ DCHECK_EQ(0, result);
USE(result);
}
« no previous file with comments | « src/base/platform/platform-openbsd.cc ('k') | src/base/platform/platform-qnx.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698