Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/parser-shell.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index 1004d965c1b0e0590c157eb40d45b2792544511b..9a0a3ba5029de0aec6381e3e30b7dedc6cbd4d03 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -62,7 +62,6 @@ legal/copyright
readability/boost
readability/braces
readability/casting
-readability/check
readability/constructors
readability/fn_size
readability/function
@@ -102,6 +101,7 @@ whitespace/tab
whitespace/todo
""".split()
+# TODO(bmeurer): Fix and re-enable readability/check
LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
« no previous file with comments | « tools/parser-shell.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698