Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/compiler/code-generator.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/code-generator-impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index 94f0d901d15df7d286f9aaba30db24d2578a337d..dfd18cc4ee0b456d8e1bf049eb492bc0f63f25a8 100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -136,7 +136,7 @@ void CodeGenerator::AssembleInstruction(Instruction* instr) {
void CodeGenerator::AssembleSourcePosition(SourcePositionInstruction* instr) {
SourcePosition source_position = instr->source_position();
if (source_position == current_source_position_) return;
- ASSERT(!source_position.IsInvalid());
+ DCHECK(!source_position.IsInvalid());
if (!source_position.IsUnknown()) {
int code_pos = source_position.raw();
masm()->positions_recorder()->RecordPosition(source_position.raw());
@@ -223,7 +223,7 @@ void CodeGenerator::PopulateDeoptimizationData(Handle<Code> code_object) {
// Populate the return address patcher entries.
for (int i = 0; i < patch_count; ++i) {
LazyDeoptimizationEntry entry = lazy_deoptimization_entries_[i];
- ASSERT(entry.position_after_call() == entry.continuation()->pos() ||
+ DCHECK(entry.position_after_call() == entry.continuation()->pos() ||
IsNopForSmiCodeInlining(code_object, entry.position_after_call(),
entry.continuation()->pos()));
data->SetReturnAddressPc(i, Smi::FromInt(entry.position_after_call()));
@@ -267,7 +267,7 @@ int CodeGenerator::DefineDeoptimizationLiteral(Handle<Object> literal) {
void CodeGenerator::BuildTranslation(Instruction* instr,
int deoptimization_id) {
// We should build translation only once.
- ASSERT_EQ(NULL, deoptimization_states_[deoptimization_id]);
+ DCHECK_EQ(NULL, deoptimization_states_[deoptimization_id]);
// TODO(jarin) This should build translation codes from the instruction inputs
// and from the framestate descriptor. At the moment, we only create a dummy
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/code-generator-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698