Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: src/typing.cc

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/types-inl.h ('k') | src/unicode.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 2eca59eeabfc48adfdcfc460899659c7d93c7f3b..136f72271c8029409cfa60e543309dff259aaffb 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -28,7 +28,7 @@ AstTyper::AstTyper(CompilationInfo* info)
#define RECURSE(call) \
do { \
- ASSERT(!visitor->HasStackOverflow()); \
+ DCHECK(!visitor->HasStackOverflow()); \
call; \
if (visitor->HasStackOverflow()) return; \
} while (false)
@@ -76,7 +76,7 @@ void AstTyper::ObserveTypesAtOsrEntry(IterationStatement* stmt) {
Scope* scope = info_->scope();
// Assert that the frame on the stack belongs to the function we want to OSR.
- ASSERT_EQ(*info_->closure(), frame->function());
+ DCHECK_EQ(*info_->closure(), frame->function());
int params = scope->num_parameters();
int locals = scope->StackLocalCount();
@@ -119,7 +119,7 @@ void AstTyper::ObserveTypesAtOsrEntry(IterationStatement* stmt) {
#define RECURSE(call) \
do { \
- ASSERT(!HasStackOverflow()); \
+ DCHECK(!HasStackOverflow()); \
call; \
if (HasStackOverflow()) return; \
} while (false)
@@ -436,7 +436,7 @@ void AstTyper::VisitAssignment(Assignment* expr) {
if (!expr->IsUninitialized()) {
if (prop->key()->IsPropertyName()) {
Literal* lit_key = prop->key()->AsLiteral();
- ASSERT(lit_key != NULL && lit_key->value()->IsString());
+ DCHECK(lit_key != NULL && lit_key->value()->IsString());
Handle<String> name = Handle<String>::cast(lit_key->value());
oracle()->AssignmentReceiverTypes(id, name, expr->GetReceiverTypes());
} else {
@@ -484,7 +484,7 @@ void AstTyper::VisitProperty(Property* expr) {
if (!expr->IsUninitialized()) {
if (expr->key()->IsPropertyName()) {
Literal* lit_key = expr->key()->AsLiteral();
- ASSERT(lit_key != NULL && lit_key->value()->IsString());
+ DCHECK(lit_key != NULL && lit_key->value()->IsString());
Handle<String> name = Handle<String>::cast(lit_key->value());
oracle()->PropertyReceiverTypes(id, name, expr->GetReceiverTypes());
} else {
« no previous file with comments | « src/types-inl.h ('k') | src/unicode.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698