Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Side by Side Diff: tools/presubmit.py

Issue 430503007: Rename ASSERT* to DCHECK*. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE and fixes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/parser-shell.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 build/endif_comment 55 build/endif_comment
56 build/forward_decl 56 build/forward_decl
57 build/include_alpha 57 build/include_alpha
58 build/include_order 58 build/include_order
59 build/printf_format 59 build/printf_format
60 build/storage_class 60 build/storage_class
61 legal/copyright 61 legal/copyright
62 readability/boost 62 readability/boost
63 readability/braces 63 readability/braces
64 readability/casting 64 readability/casting
65 readability/check
66 readability/constructors 65 readability/constructors
67 readability/fn_size 66 readability/fn_size
68 readability/function 67 readability/function
69 readability/multiline_comment 68 readability/multiline_comment
70 readability/multiline_string 69 readability/multiline_string
71 readability/streams 70 readability/streams
72 readability/todo 71 readability/todo
73 readability/utf8 72 readability/utf8
74 runtime/arrays 73 runtime/arrays
75 runtime/casting 74 runtime/casting
(...skipping 19 matching lines...) Expand all
95 whitespace/indent 94 whitespace/indent
96 whitespace/labels 95 whitespace/labels
97 whitespace/line_length 96 whitespace/line_length
98 whitespace/newline 97 whitespace/newline
99 whitespace/operators 98 whitespace/operators
100 whitespace/parens 99 whitespace/parens
101 whitespace/tab 100 whitespace/tab
102 whitespace/todo 101 whitespace/todo
103 """.split() 102 """.split()
104 103
104 # TODO(bmeurer): Fix and re-enable readability/check
105 105
106 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 106 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
107 107
108 108
109 def CppLintWorker(command): 109 def CppLintWorker(command):
110 try: 110 try:
111 process = subprocess.Popen(command, stderr=subprocess.PIPE) 111 process = subprocess.Popen(command, stderr=subprocess.PIPE)
112 process.wait() 112 process.wait()
113 out_lines = "" 113 out_lines = ""
114 error_count = -1 114 error_count = -1
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 success = SourceProcessor().Run(workspace) and success 444 success = SourceProcessor().Run(workspace) and success
445 success = CheckGeneratedRuntimeTests(workspace) and success 445 success = CheckGeneratedRuntimeTests(workspace) and success
446 if success: 446 if success:
447 return 0 447 return 0
448 else: 448 else:
449 return 1 449 return 1
450 450
451 451
452 if __name__ == '__main__': 452 if __name__ == '__main__':
453 sys.exit(Main()) 453 sys.exit(Main())
OLDNEW
« no previous file with comments | « tools/parser-shell.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698