Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 430503002: DevTools: Remove console last result $_ on console clear. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Remove console last result $_ on console clear. BUG=398336 R=loislo, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179179

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -9 lines) Patch
M LayoutTests/inspector/console/console-eval-syntax-error-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-last-result.html View 1 chunk +35 lines, -8 lines 0 comments Download
M LayoutTests/inspector/console/console-last-result-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
aandrey
6 years, 4 months ago (2014-07-29 13:02:42 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-07-29 13:16:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/430503002/1
6 years, 4 months ago (2014-07-29 13:17:24 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 14:25:04 UTC) #4
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 14:26:30 UTC) #5
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 14:28:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/430503002/1
6 years, 4 months ago (2014-07-29 14:29:11 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 15:30:02 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 15:54:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/18109)
6 years, 4 months ago (2014-07-29 15:54:18 UTC) #10
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 15:57:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/430503002/1
6 years, 4 months ago (2014-07-29 15:58:23 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 16:34:19 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 17:01:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/18119)
6 years, 4 months ago (2014-07-29 17:01:13 UTC) #15
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 17:50:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/430503002/20001
6 years, 4 months ago (2014-07-29 17:51:43 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-29 19:01:22 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 20:27:23 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19530)
6 years, 4 months ago (2014-07-29 20:27:24 UTC) #20
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-29 21:41:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/430503002/20001
6 years, 4 months ago (2014-07-29 21:42:37 UTC) #22
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 22:19:15 UTC) #23
Message was sent while issue was closed. 
Change committed as 179179

Powered by Google App Engine
This is Rietveld 408576698