Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: Source/devtools/front_end/sdk/DOMModel.js

Issue 430463002: DevTools: highlight page regions as paths, not quads (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/common/Color.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1541 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 1552
1553 if (mode === "all" || mode === "padding") 1553 if (mode === "all" || mode === "padding")
1554 highlightConfig.paddingColor = WebInspector.Color.PageHighlight.Padd ing.toProtocolRGBA(); 1554 highlightConfig.paddingColor = WebInspector.Color.PageHighlight.Padd ing.toProtocolRGBA();
1555 1555
1556 if (mode === "all" || mode === "border") 1556 if (mode === "all" || mode === "border")
1557 highlightConfig.borderColor = WebInspector.Color.PageHighlight.Borde r.toProtocolRGBA(); 1557 highlightConfig.borderColor = WebInspector.Color.PageHighlight.Borde r.toProtocolRGBA();
1558 1558
1559 if (mode === "all" || mode === "margin") 1559 if (mode === "all" || mode === "margin")
1560 highlightConfig.marginColor = WebInspector.Color.PageHighlight.Margi n.toProtocolRGBA(); 1560 highlightConfig.marginColor = WebInspector.Color.PageHighlight.Margi n.toProtocolRGBA();
1561 1561
1562 if (mode === "all") 1562 if (mode === "all") {
1563 highlightConfig.eventTargetColor = WebInspector.Color.PageHighlight. EventTarget.toProtocolRGBA(); 1563 highlightConfig.eventTargetColor = WebInspector.Color.PageHighlight. EventTarget.toProtocolRGBA();
1564 1564 highlightConfig.shapeColor = WebInspector.Color.PageHighlight.Shape. toProtocolRGBA();
1565 highlightConfig.shapeMarginColor = WebInspector.Color.PageHighlight. ShapeMargin.toProtocolRGBA();
1566 }
1565 return highlightConfig; 1567 return highlightConfig;
1566 }, 1568 },
1567 1569
1568 /** 1570 /**
1569 * @param {!WebInspector.DOMNode} node 1571 * @param {!WebInspector.DOMNode} node
1570 * @param {function(?Protocol.Error, ...)=} callback 1572 * @param {function(?Protocol.Error, ...)=} callback
1571 * @return {function(...)} 1573 * @return {function(...)}
1572 * @template T 1574 * @template T
1573 */ 1575 */
1574 _markRevision: function(node, callback) 1576 _markRevision: function(node, callback)
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
1942 * @param {boolean} inspectUAShadowDOM 1944 * @param {boolean} inspectUAShadowDOM
1943 * @param {!DOMAgent.HighlightConfig} config 1945 * @param {!DOMAgent.HighlightConfig} config
1944 * @param {function(?Protocol.Error)=} callback 1946 * @param {function(?Protocol.Error)=} callback
1945 */ 1947 */
1946 setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callbac k) 1948 setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callbac k)
1947 { 1949 {
1948 WebInspector.overridesSupport.setTouchEmulationSuspended(enabled); 1950 WebInspector.overridesSupport.setTouchEmulationSuspended(enabled);
1949 this._agent.setInspectModeEnabled(enabled, inspectUAShadowDOM, config, c allback); 1951 this._agent.setInspectModeEnabled(enabled, inspectUAShadowDOM, config, c allback);
1950 } 1952 }
1951 } 1953 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/common/Color.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698