DevTools: highlight page regions as paths, not quads

DevTools: highlight page regions as paths, not quads

We used to pass a typed set of quads plus the config that specified
color for each type of quad. This is not flexible enough to cover
the needs of highlighting of different types of render objects.
This switches to a more flexible interface passing an array of paths
with fill & outline colors specified for each path.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179150

[pfeldman, 2014-07-29 10:47:08]

lgtm

[dgozman, 2014-07-29 11:00:41]

lgtm

https://codereview.chromium.org/430463002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorOverlayPage.html (right):

https://codereview.chromium.org/430463002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorOverlayPage.html:511:
context.quadraticCurveTo.apply(context, extractPoints(4));
extractPoints(2)

https://codereview.chromium.org/430463002/diff/20001/Source/devtools/protocol...
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/430463002/diff/20001/Source/devtools/protocol...
Source/devtools/protocol.json:2015: { "name": "shapeColor", "$ref": "RGBA",
"optional": true, "hidden": true, "description": "The event target element shape
fill color (default: transparent)." },
These shape colors has nothing to do with event target.

[caseq, 2014-07-29 12:18:57]

On 2014/07/29 11:00:41, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/430463002/diff/20001/Source/core/inspector/In...
> File Source/core/inspector/InspectorOverlayPage.html (right):
> 
>
https://codereview.chromium.org/430463002/diff/20001/Source/core/inspector/In...
> Source/core/inspector/InspectorOverlayPage.html:511:
> context.quadraticCurveTo.apply(context, extractPoints(4));
> extractPoints(2)

Thanks a lot for noticing this! Fixed!
> 
>
https://codereview.chromium.org/430463002/diff/20001/Source/devtools/protocol...
> File Source/devtools/protocol.json (right):
> 
>
https://codereview.chromium.org/430463002/diff/20001/Source/devtools/protocol...
> Source/devtools/protocol.json:2015: { "name": "shapeColor", "$ref": "RGBA",
> "optional": true, "hidden": true, "description": "The event target element
shape
> fill color (default: transparent)." },
> These shape colors has nothing to do with event target.

Ditto.

[caseq, 2014-07-29 12:49:24]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-07-29 12:50:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/430463002/40001

[commit-bot: I haz the power, 2014-07-29 13:54:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-29 14:58:32]

Change committed as 179150