Hopefully make DownloadTest.UnknownSize not-flaky.

chrome/test/ui/ui_test.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ui/ui_test.h"
 
 #include <set>
 #include <vector>
 
 #include "base/base_switches.h"
@@ skipping 480 matching lines @@
   ASSERT_FALSE(is_timeout) << url.spec();
 }
 
 // TODO(port): this #if effectively cuts out half of this file on
 // non-Windows platforms, and is a temporary hack to get things
 // building.
 #if defined(OS_WIN)
 bool UITest::WaitForDownloadShelfVisible(TabProxy* tab) {
   const int kCycles = 20;
   for (int i = 0; i < kCycles; i++) {
+    // Give it a chance to catch up.
+    PlatformThread::Sleep(action_max_timeout_ms() / kCycles);
+
     bool visible = false;
     if (!tab->IsShelfVisible(&visible))
-      return false;  // Some error.
+      continue;
     if (visible)
       return true;  // Got the download shelf.
-
-    // Give it a chance to catch up.
-    PlatformThread::Sleep(action_max_timeout_ms() / kCycles);
   }
   return false;
 }
 
 bool UITest::WaitForFindWindowVisibilityChange(BrowserProxy* browser,
                                                bool wait_for_open) {
   const int kCycles = 20;
   for (int i = 0; i < kCycles; i++) {
     bool visible = false;
     if (!browser->IsFindWindowFullyVisible(&visible))
@@ skipping 279 matching lines @@
                               const std::wstring& units,
                               bool important) {
   // <*>RESULT <graph_name>: <trace_name>= <value> <units>
   // <*>RESULT <graph_name>: <trace_name>= {<mean>, <std deviation>} <units>
   // <*>RESULT <graph_name>: <trace_name>= [<value>,value,value,...,] <units>
   wprintf(L"%lsRESULT %ls%ls: %ls= %ls%ls%ls %ls\n",
           important ? L"*" : L"", measurement.c_str(), modifier.c_str(),
           trace.c_str(), prefix.c_str(), values.c_str(), suffix.c_str(),
           units.c_str());
 }