Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: chrome/browser/download/download_uitest.cc

Issue 43046: Hopefully make DownloadTest.UnknownSize not-flaky. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <shlwapi.h> 5 #include <shlwapi.h>
6 #include <sstream> 6 #include <sstream>
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 ASSERT_TRUE(tab_proxy.get()); 221 ASSERT_TRUE(tab_proxy.get());
222 EXPECT_TRUE(WaitForDownloadShelfVisible(tab_proxy.get())); 222 EXPECT_TRUE(WaitForDownloadShelfVisible(tab_proxy.get()));
223 } 223 }
224 224
225 // UnknownSize and KnownSize are tests which depend on 225 // UnknownSize and KnownSize are tests which depend on
226 // URLRequestSlowDownloadJob to serve content in a certain way. Data will be 226 // URLRequestSlowDownloadJob to serve content in a certain way. Data will be
227 // sent in two chunks where the first chunk is 35K and the second chunk is 10K. 227 // sent in two chunks where the first chunk is 35K and the second chunk is 10K.
228 // The test will first attempt to download a file; but the server will "pause" 228 // The test will first attempt to download a file; but the server will "pause"
229 // in the middle until the server receives a second request for 229 // in the middle until the server receives a second request for
230 // "download-finish. At that time, the download will finish. 230 // "download-finish. At that time, the download will finish.
231 // TODO(paul): Reenable, http://code.google.com/p/chromium/issues/detail?id=7191 231 TEST_F(DownloadTest, UnknownSize) {
232 TEST_F(DownloadTest, DISABLED_UnknownSize) {
233 std::wstring url(URLRequestSlowDownloadJob::kUnknownSizeUrl); 232 std::wstring url(URLRequestSlowDownloadJob::kUnknownSizeUrl);
234 std::wstring filename = file_util::GetFilenameFromPath(url); 233 std::wstring filename = file_util::GetFilenameFromPath(url);
235 RunSizeTest(url, L"32.0 KB - " + filename, L"100% - " + filename); 234 RunSizeTest(url, L"32.0 KB - " + filename, L"100% - " + filename);
236 } 235 }
237 236
238 // http://b/1158253 237 // http://b/1158253
239 TEST_F(DownloadTest, DISABLED_KnownSize) { 238 TEST_F(DownloadTest, DISABLED_KnownSize) {
240 std::wstring url(URLRequestSlowDownloadJob::kKnownSizeUrl); 239 std::wstring url(URLRequestSlowDownloadJob::kKnownSizeUrl);
241 std::wstring filename = file_util::GetFilenameFromPath(url); 240 std::wstring filename = file_util::GetFilenameFromPath(url);
242 RunSizeTest(url, L"71% - " + filename, L"100% - " + filename); 241 RunSizeTest(url, L"71% - " + filename, L"100% - " + filename);
243 } 242 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698