Issue 430443003: Use unchecked InputStream methods in the android_webview.

Issue 430443003: Use unchecked InputStream methods in the android_webview. (Closed)

Created:
6 years, 4 months ago by mkosiba (inactive)

Modified:
6 years, 4 months ago

Reviewers:
Torne

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't crash on InputStream exceptions in the android_webview. The InputStream methods can, under normal operation, throw an IOException. If such a stream is being read by the WebView it will crash. This change addresses that by introducing a wrapper class that deals with the exceptions. BUG=157880 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286214

Patch Set 1 #

Patch Set 2 : remove old InputStream jni #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -23 lines)			Patch
A	android_webview/java/src/org/chromium/android_webview/InputStreamUtil.java	View		1 chunk	+70 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	android_webview/native/input_stream_impl.cc	View		4 chunks	+16 lines, -13 lines	0 comments	Download
M	android_webview/native/input_stream_unittest.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	android_webview/native/webview_native.gyp	View	1	3 chunks	+1 line, -10 lines	0 comments	Download
M	android_webview/unittestjava/src/org/chromium/android_webview/unittest/InputStreamUnittest.java	View		2 chunks	+26 lines, -0 lines	0 comments	Download