Issue 430363004: WaitableEvent: allow TimedWait to synchronise its own destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430363004: WaitableEvent: allow TimedWait to synchronise its own destruction.

Created:
6 years, 4 months ago by agl

Modified:
5 years, 3 months ago

Reviewers:
yhirano

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

WaitableEvent: allow TimedWait to synchronise its own destruction. BUG=397435

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	base/synchronization/waitable_event.h	View		2 chunks	+12 lines, -2 lines	1 comment	Download
	M	base/synchronization/waitable_event_posix.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

yhirano

lgtm https://codereview.chromium.org/430363004/diff/1/base/synchronization/waitable_event.h File base/synchronization/waitable_event.h (right): https://codereview.chromium.org/430363004/diff/1/base/synchronization/waitable_event.h#newcode81 base/synchronization/waitable_event.h:81: // e.Wait(); e->

6 years, 4 months ago (2014-08-01 01:12:47 UTC) #3

Removing myself from the reviewers list.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages