Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 43033002: run-bindings-tests: better error message (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
CC:
blink-reviews, johnjbarton
Visibility:
Public.

Description

run-bindings-tests: better error message Bindings test results can get out of sync, causing mysterious failures, as per thread "git cl upload > run-bindings-tests failed" https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hQ2hqTZyLOw This gives a more useful error message, explaining how to fix the problem. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/bindings/main.py View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Adam, haraken, error message fix so r-b-t failures are less confusing; how does it look?
7 years, 2 months ago (2013-10-25 02:12:16 UTC) #1
abarth-chromium
This looks great. Thanks! LGTM
7 years, 2 months ago (2013-10-25 02:19:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/43033002/1
7 years, 2 months ago (2013-10-25 03:16:09 UTC) #3
haraken
LGTM
7 years, 2 months ago (2013-10-25 05:05:00 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 05:05:16 UTC) #5
Message was sent while issue was closed.
Change committed as 160540

Powered by Google App Engine
This is Rietveld 408576698