Issue 430243002: Use ExtensionRegistry in EventRouter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430243002: Use ExtensionRegistry in EventRouter (Closed)

Created:
6 years, 4 months ago by limasdf

Modified:
6 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Use ExtensionRegistry instead of deprecated extension's notification in EventRouter. And Make EventRouterTest inherit ExtensionsTest to setup for test. R=kalman@chromium.org BUG=354046 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287383

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -29 lines)			Patch
M	extensions/browser/event_router.h	View	4 chunks	+14 lines, -0 lines	0 comments	Download
M	extensions/browser/event_router.cc	View	3 chunks	+20 lines, -28 lines	0 comments	Download
M	extensions/browser/event_router_unittest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

not at google - send to devlin

lgtm +jamescook FYI on the extensions test change

6 years, 4 months ago (2014-08-04 15:38:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/430243002/60001

6 years, 4 months ago (2014-08-04 15:40:30 UTC) #4

Message was sent while issue was closed.

Change committed as 287383