Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 430213004: Register all ExternalReferences in serializer code. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Removed unused ExternalReferences, added few ASSERTs Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/serialize.cc ('K') | « src/serialize.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 void MathExpGenerator::EmitMathExp(MacroAssembler* masm, 577 void MathExpGenerator::EmitMathExp(MacroAssembler* masm,
578 XMMRegister input, 578 XMMRegister input,
579 XMMRegister result, 579 XMMRegister result,
580 XMMRegister double_scratch, 580 XMMRegister double_scratch,
581 Register temp1, 581 Register temp1,
582 Register temp2) { 582 Register temp2) {
583 ASSERT(!input.is(result)); 583 ASSERT(!input.is(result));
584 ASSERT(!input.is(double_scratch)); 584 ASSERT(!input.is(double_scratch));
585 ASSERT(!result.is(double_scratch)); 585 ASSERT(!result.is(double_scratch));
586 ASSERT(!temp1.is(temp2)); 586 ASSERT(!temp1.is(temp2));
587 // Serializer does not know how to encode references to math_exp_constants
588 // table. See ExternalReferenceTable::PopulateTable.
589 ASSERT(!masm->serializer_enabled());
587 ASSERT(ExternalReference::math_exp_constants(0).address() != NULL); 590 ASSERT(ExternalReference::math_exp_constants(0).address() != NULL);
588 591
589 Label done; 592 Label done;
590 593
591 __ Move(kScratchRegister, ExternalReference::math_exp_constants(0)); 594 __ Move(kScratchRegister, ExternalReference::math_exp_constants(0));
592 __ movsd(double_scratch, Operand(kScratchRegister, 0 * kDoubleSize)); 595 __ movsd(double_scratch, Operand(kScratchRegister, 0 * kDoubleSize));
593 __ xorpd(result, result); 596 __ xorpd(result, result);
594 __ ucomisd(double_scratch, input); 597 __ ucomisd(double_scratch, input);
595 __ j(above_equal, &done); 598 __ j(above_equal, &done);
596 __ ucomisd(input, Operand(kScratchRegister, 1 * kDoubleSize)); 599 __ ucomisd(input, Operand(kScratchRegister, 1 * kDoubleSize));
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize. 708 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize.
706 return Operand(base_reg_, argument_count_reg_, times_pointer_size, 709 return Operand(base_reg_, argument_count_reg_, times_pointer_size,
707 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize); 710 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize);
708 } 711 }
709 } 712 }
710 713
711 714
712 } } // namespace v8::internal 715 } } // namespace v8::internal
713 716
714 #endif // V8_TARGET_ARCH_X64 717 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/serialize.cc ('K') | « src/serialize.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698