Register all ExternalReferences in serializer code.

src/serialize.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/base/platform/platform.h"
 #include "src/bootstrapper.h"
@@ skipping 509 matching lines @@
       UNCLASSIFIED,
       66,
       "Debug::after_break_target_address()");
 
   Add(ExternalReference::debug_restarter_frame_function_pointer_address(
           isolate).address(),
       UNCLASSIFIED,
       67,
       "Debug::restarter_frame_function_pointer_address()");
 
+  Add(ExternalReference::flush_icache_function(isolate).address(),

[Slava Chigrin, 2014/07/31 16:28:44]

Comment in the start of this function says that "The following populates all of
the different type of external references into the ExternalReferenceTable." But
seems these external references were missed. Even if current built-in snapshot
does not use them, may be worth to add them to table to avoid problems in
future?

[Yang, 2014/08/05 11:02:43]

Acknowledged.

+      UNCLASSIFIED,
+      68,
+      "Isolate::flush_icache_function");
+  Add(ExternalReference::log_enter_external_function(isolate).address(),
+      UNCLASSIFIED,
+      69,
+      "Isolate::log_enter_external_function");
+  Add(ExternalReference::log_leave_external_function(isolate).address(),
+      UNCLASSIFIED,
+      70,
+      "Isolate::log_leave_external_function");
+  Add(ExternalReference::address_of_minus_one_half().address(),
+      UNCLASSIFIED,
+      71,
+      "Isolate::address_of_minus_one_half");
+  Add(ExternalReference::address_of_zero().address(),

[Slava Chigrin, 2014/07/31 16:28:44]

Seems address_of_zero(), address_of_uint8_max_value() and
heap_always_allocate_scope_depth() external references not used at all in
codebase now. What do you think is better - add them to table since they can be
used in future, or just remove them from ExternalReference class?

[Yang, 2014/08/05 11:02:43]

Removing them entirely makes more sense. This also goes for
address_of_minus_zero().

+      UNCLASSIFIED,
+      72,
+      "Isolate::address_of_zero");
+  Add(ExternalReference::address_of_uint8_max_value().address(),
+      UNCLASSIFIED,
+      73,
+      "Isolate::address_of_uint8_max_value");
+  Add(ExternalReference::math_log_double_function(isolate).address(),
+      UNCLASSIFIED,
+      74,
+      "Isolate::math_log_double_function");
+  Add(ExternalReference::math_exp_log_table().address(),
+      UNCLASSIFIED,
+      75,
+      "Isolate::math_exp_log_table");
+  Add(ExternalReference::stress_deopt_count(isolate).address(),
+      UNCLASSIFIED,
+      76,
+      "Isolate::stress_deopt_count");
+  Add(ExternalReference::debug_is_active_address(isolate).address(),
+      UNCLASSIFIED,
+      77,
+      "Isolate::debug_is_active_address");
+  Add(ExternalReference::heap_always_allocate_scope_depth(isolate).address(),
+      UNCLASSIFIED,
+      78,
+      "Isolate::heap_always_allocate_scope_depth");
+

[Slava Chigrin, 2014/07/31 16:28:44]

There are also few external references generated in math_exp_constants()
function. I am going to submit their registration in separate CL. Or I can add
them to this CL, which is better?

[Yang, 2014/08/05 11:02:43]

There is no need to include the math_exp_* references, as they are always
created on-demand. I would prefer not to invest in unnecessary complexity here.
Please also remove math_exp_log_table.

To better catch bugs in the future, we could add a
  DCHECK(!masm->serializer_enabled());
to EmitMathExp with a comment stating that we do not expect this code to end up
being serialized.

   // Add a small set of deopt entry addresses to encoder without generating the
   // deopt table code, which isn't possible at deserialization time.
   HandleScope scope(isolate);
   for (int entry = 0; entry < kDeoptTableSerializeEntryCount; ++entry) {
     Address address = Deoptimizer::GetDeoptimizationEntry(
         isolate,
         entry,
         Deoptimizer::LAZY,
         Deoptimizer::CALCULATE_ENTRY_ADDRESS);
     Add(address, LAZY_DEOPTIMIZATION, entry, "lazy_deopt");
@@ skipping 1530 matching lines @@
 
 int SerializedCodeData::CheckSum(String* string) {
   int checksum = Version::Hash();
 #ifdef DEBUG
   uint32_t seed = static_cast<uint32_t>(checksum);
   checksum = static_cast<int>(IteratingStringHasher::Hash(string, seed));
 #endif  // DEBUG
   return checksum;
 }
 } }  // namespace v8::internal