Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_if_needed.cpp

Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: TraceIfNeeded support Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/trace_if_needed.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/ignore_fields.cpp b/tools/clang/blink_gc_plugin/tests/trace_if_needed.cpp
similarity index 52%
copy from tools/clang/blink_gc_plugin/tests/ignore_fields.cpp
copy to tools/clang/blink_gc_plugin/tests/trace_if_needed.cpp
index 118af75424a6ec892fcd4c9bba743b5bb1ebec56..563c6cc125f46a0a3328c06b61ac2b0c744331a8 100644
--- a/tools/clang/blink_gc_plugin/tests/ignore_fields.cpp
+++ b/tools/clang/blink_gc_plugin/tests/trace_if_needed.cpp
@@ -2,14 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ignore_fields.h"
+#include "trace_if_needed.h"
namespace blink {
-void C::trace(Visitor* visitor)
+template<typename T>
+void TemplatedObject<T>::trace(Visitor* visitor)
{
- // Missing trace of m_one.
- // Not missing ignored field m_two.
+ TraceIfNeeded<T>::trace(visitor, &m_one);
+ // Missing trace of m_two
}
}
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/trace_if_needed.h ('k') | tools/clang/blink_gc_plugin/tests/trace_if_needed.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698