tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp - Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp

Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: TraceIfNeeded support Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp

index 475d40f7d9b72533c32d1c51eb15c753f75eddee..977951058f77059fe8a93278d615cc6be3937aa9 100644

--- a/tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp

+++ b/tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp

@@ -7,7 +7,7 @@

namespace blink {

void PartObject::trace(Visitor* visitor) {

- // Missing visitor->trace(m_obj1);

+ m_obj1->trace(visitor); // Don't allow direct tracing.

visitor->trace(m_obj2);

// Missing visitor->trace(m_obj3);

}