tools/clang/blink_gc_plugin/Config.h - Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/Config.h

Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: TraceIfNeeded support Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/Config.h

diff --git a/tools/clang/blink_gc_plugin/Config.h b/tools/clang/blink_gc_plugin/Config.h

index 9dc97798821919d93237a56d17e07a44b514d12e..48f611b3f442eb491d4a2bd9d75d2fe54dfe41e8 100644

--- a/tools/clang/blink_gc_plugin/Config.h

+++ b/tools/clang/blink_gc_plugin/Config.h

@@ -17,6 +17,7 @@ const char kFinalizeName[] = "finalizeGarbageCollectedObject";

const char kTraceAfterDispatchName[] = "traceAfterDispatch";

const char kRegisterWeakMembersName[] = "registerWeakMembers";

const char kHeapAllocatorName[] = "HeapAllocator";

+const char kTraceIfNeededName[] = "TraceIfNeeded";

class Config {

public:

@@ -139,7 +140,7 @@ class Config {

static bool IsVisitor(const std::string& name) { return name == "Visitor"; }

- static bool IsTraceMethod(clang::CXXMethodDecl* method,

+ static bool IsTraceMethod(clang::FunctionDecl* method,

bool* isTraceAfterDispatch = 0) {

if (method->getNumParams() != 1)

return false;