tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp - Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

Issue 430213003: Blink GC plugin: Require that fields are actually traced by the visitor and identify tracing of dep… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('K') | « tools/clang/blink_gc_plugin/Config.h ('k') | tools/clang/blink_gc_plugin/tests/fields_require_tracing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

index c0174e88c5b25f0a679094474f88dcd0a229fb6a..99ccbb6393b34a8a5b865712da1f7b6f70ea5f25 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

@@ -23,7 +23,6 @@ void GCedClassWithAScriptWrappableBase::trace(Visitor* visitor)

void GCedClassWithAScriptWrappableAndAFinalizableBase::trace(Visitor* visitor)

{

- A::trace(visitor);

GCedClassWithAScriptWrappableBase::trace(visitor);

}