Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: net/base/net_util_unittest.cc

Issue 430193002: Wire 'blink::Platform::isHostnameReservedIPAddress()' to 'net::IsReservedIPAddress()'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_unittest.cc
diff --git a/net/base/net_util_unittest.cc b/net/base/net_util_unittest.cc
index 674a7259121f041f9eceda75b639ba3cc7764d46..8306db53c2b86fc4c2687e88176d5fe74f5c9807 100644
--- a/net/base/net_util_unittest.cc
+++ b/net/base/net_util_unittest.cc
@@ -524,6 +524,31 @@ TEST(NetUtilTest, ConvertIPv4NumberToIPv6Number) {
EXPECT_EQ("::ffff:c0a8:1", IPAddressToString(ipv6_number));
}
+TEST(NetUtilTest, ParseURLHostnameToNumber_FailParse) {
+ IPAddressNumber number;
+
+ EXPECT_FALSE(ParseURLHostnameToNumber("bad value", &number));
+ EXPECT_FALSE(ParseURLHostnameToNumber("bad:value", &number));
+ EXPECT_FALSE(ParseURLHostnameToNumber(std::string(), &number));
+ EXPECT_FALSE(ParseURLHostnameToNumber("192.168.0.1:30", &number));
+ EXPECT_FALSE(ParseURLHostnameToNumber(" 192.168.0.1 ", &number));
+ EXPECT_FALSE(ParseURLHostnameToNumber("::1", &number));
+}
+
+TEST(NetUtilTest, ParseURLHostnameToNumber_IPv4) {
+ IPAddressNumber number;
+ EXPECT_TRUE(ParseURLHostnameToNumber("192.168.0.1", &number));
+ EXPECT_EQ("192,168,0,1", DumpIPNumber(number));
+ EXPECT_EQ("192.168.0.1", IPAddressToString(number));
+}
+
+TEST(NetUtilTest, ParseURLHostnameToNumber_IPv6) {
+ IPAddressNumber number;
+ EXPECT_TRUE(ParseURLHostnameToNumber("[1:abcd::3:4:ff]", &number));
+ EXPECT_EQ("0,1,171,205,0,0,0,0,0,0,0,3,0,4,0,255", DumpIPNumber(number));
+ EXPECT_EQ("1:abcd::3:4:ff", IPAddressToString(number));
+}
+
TEST(NetUtilTest, IsIPv4Mapped) {
IPAddressNumber ipv4_number;
EXPECT_TRUE(ParseIPLiteralToNumber("192.168.0.1", &ipv4_number));
« no previous file with comments | « net/base/net_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698