Change to make the 'save as...' dialog choose the default download path you h...

Change to make the 'save as...' dialog choose the default download path you have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path.
This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set.

Patch contributed by Paul Robinson <paulRobinson85@googlemail.com>;

BUG=8049

[M-A Ruel, 2009-03-10 13:27:42]

http://codereview.chromium.org/43016/diff/1/2
File chrome/browser/download/save_package.cc (right):

http://codereview.chromium.org/43016/diff/1/2#newcode968
Line 968: &default_save_path))
You messed up the accolades. Add an { there and fix alignment.

[Paul Robinson, 2009-03-10 14:43:56]

On 2009/03/10 13:27:42, M-A wrote:
> http://codereview.chromium.org/43016/diff/1/2
> File chrome/browser/download/save_package.cc (right):
> 
> http://codereview.chromium.org/43016/diff/1/2#newcode968
> Line 968: &default_save_path))
> You messed up the accolades. Add an { there and fix alignment.

Fixed these, apologies.

[M-A Ruel, 2009-03-10 14:47:25]

lgtm, will try to commit later today.

[Paul Robinson, 2009-03-10 14:48:38]

On 2009/03/10 14:47:25, M-A wrote:
> lgtm, will try to commit later today.

Thanks, this is my first bug, can I be added to the AUTHORS file too? also can I
be added to the project?

[Paul Robinson, 2009-03-10 15:28:51]

I have added the AUTHORS file to this change

[Paul Robinson, 2009-03-11 11:12:09]

On 2009/03/10 15:28:51, Paul Robinson wrote:
> I have added the AUTHORS file to this change

Hey there, was this submitted?

[Paul Robinson, 2009-03-11 16:54:11]

On 2009/03/11 11:12:09, Paul Robinson wrote:
> On 2009/03/10 15:28:51, Paul Robinson wrote:
> > I have added the AUTHORS file to this change
> 
> Hey there, was this submitted?

I've updated this to convert from wstring. Any idea why this built successfully
when I tried but did not on the build server? Is there something extra I should
be setting in visual studio?

[M-A Ruel, 2009-03-11 18:56:23]

On 2009/03/11 16:54:11, Paul Robinson wrote:
> On 2009/03/11 11:12:09, Paul Robinson wrote:
> > On 2009/03/10 15:28:51, Paul Robinson wrote:
> > > I have added the AUTHORS file to this change
> > 
> > Hey there, was this submitted?
> 
> I've updated this to convert from wstring. Any idea why this built
successfully
> when I tried but did not on the build server? Is there something extra I
should
> be setting in visual studio?

It failed on linux and mac. I never said that it failed on windows. The newest
patch passed on both and was committed as revision 11465.