Fixed a few space leaks.

test/cctest/compiler/test-scheduler.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/generic-node-inl.h"
 #include "src/compiler/generic-node.h"
@@ skipping 128 matching lines @@
   CheckRPONumbers(order, 2, true);
   BasicBlock* loop[] = {schedule.entry(), schedule.exit()};
   CheckLoopContains(loop, 2);
 }
 
 
 TEST(RPOEndLoop) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
-  TestLoop* loop1 = CreateLoop(&schedule, 2);
+  SmartPointer<TestLoop> loop1(CreateLoop(&schedule, 2));
   schedule.AddSuccessor(schedule.entry(), loop1->header());
   BasicBlockVector* order = scheduler.ComputeSpecialRPO();
   CheckRPONumbers(order, 3, true);
   CheckLoopContains(loop1->nodes, loop1->count);
 }
 
 
 TEST(RPOEndLoopNested) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
-  TestLoop* loop1 = CreateLoop(&schedule, 2);
+  SmartPointer<TestLoop> loop1(CreateLoop(&schedule, 2));
   schedule.AddSuccessor(schedule.entry(), loop1->header());
   schedule.AddSuccessor(loop1->last(), schedule.entry());
   BasicBlockVector* order = scheduler.ComputeSpecialRPO();
   CheckRPONumbers(order, 3, true);
   CheckLoopContains(loop1->nodes, loop1->count);
 }
 
 
 TEST(RPODiamond) {
   HandleAndZoneScope scope;
@@ skipping 175 matching lines @@
   BasicBlock* loop3[] = {D, E};
   CheckLoopContains(loop3, 2);
 }
 
 
 TEST(RPOLoopFollow1) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
 
-  TestLoop* loop1 = CreateLoop(&schedule, 1);
-  TestLoop* loop2 = CreateLoop(&schedule, 1);
+  SmartPointer<TestLoop> loop1(CreateLoop(&schedule, 1));
+  SmartPointer<TestLoop> loop2(CreateLoop(&schedule, 1));
 
   BasicBlock* A = schedule.entry();
   BasicBlock* E = schedule.exit();
 
   schedule.AddSuccessor(A, loop1->header());
   schedule.AddSuccessor(loop1->header(), loop2->header());
   schedule.AddSuccessor(loop2->last(), E);
 
   BasicBlockVector* order = scheduler.ComputeSpecialRPO();
 
   CheckLoopContains(loop1->nodes, loop1->count);
 
   CHECK_EQ(schedule.BasicBlockCount(), static_cast<int>(order->size()));
   CheckLoopContains(loop1->nodes, loop1->count);
   CheckLoopContains(loop2->nodes, loop2->count);
-  delete loop1;
-  delete loop2;
 }
 
 
 TEST(RPOLoopFollow2) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
 
-  TestLoop* loop1 = CreateLoop(&schedule, 1);
-  TestLoop* loop2 = CreateLoop(&schedule, 1);
+  SmartPointer<TestLoop> loop1(CreateLoop(&schedule, 1));
+  SmartPointer<TestLoop> loop2(CreateLoop(&schedule, 1));
 
   BasicBlock* A = schedule.entry();
   BasicBlock* S = schedule.NewBasicBlock();
   BasicBlock* E = schedule.exit();
 
   schedule.AddSuccessor(A, loop1->header());
   schedule.AddSuccessor(loop1->header(), S);
   schedule.AddSuccessor(S, loop2->header());
   schedule.AddSuccessor(loop2->last(), E);
 
   BasicBlockVector* order = scheduler.ComputeSpecialRPO();
 
   CheckLoopContains(loop1->nodes, loop1->count);
 
   CHECK_EQ(schedule.BasicBlockCount(), static_cast<int>(order->size()));
   CheckLoopContains(loop1->nodes, loop1->count);
   CheckLoopContains(loop2->nodes, loop2->count);
-  delete loop1;
-  delete loop2;
 }
 
 
 TEST(RPOLoopFollowN) {
   HandleAndZoneScope scope;
 
   for (int size = 1; size < 5; size++) {
     for (int exit = 0; exit < size; exit++) {
       Schedule schedule(scope.main_zone());
       Scheduler scheduler(scope.main_zone(), NULL, &schedule);
-      TestLoop* loop1 = CreateLoop(&schedule, size);
-      TestLoop* loop2 = CreateLoop(&schedule, size);
+      SmartPointer<TestLoop> loop1(CreateLoop(&schedule, size));
+      SmartPointer<TestLoop> loop2(CreateLoop(&schedule, size));
       BasicBlock* A = schedule.entry();
       BasicBlock* E = schedule.exit();
 
       schedule.AddSuccessor(A, loop1->header());
       schedule.AddSuccessor(loop1->nodes[exit], loop2->header());
       schedule.AddSuccessor(loop2->nodes[exit], E);
       BasicBlockVector* order = scheduler.ComputeSpecialRPO();
       CheckLoopContains(loop1->nodes, loop1->count);
 
       CHECK_EQ(schedule.BasicBlockCount(), static_cast<int>(order->size()));
       CheckLoopContains(loop1->nodes, loop1->count);
       CheckLoopContains(loop2->nodes, loop2->count);
-      delete loop1;
-      delete loop2;
     }
   }
 }
 
 
 TEST(RPONestedLoopFollow1) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
 
-  TestLoop* loop1 = CreateLoop(&schedule, 1);
-  TestLoop* loop2 = CreateLoop(&schedule, 1);
+  SmartPointer<TestLoop> loop1(CreateLoop(&schedule, 1));
+  SmartPointer<TestLoop> loop2(CreateLoop(&schedule, 1));
 
   BasicBlock* A = schedule.entry();
   BasicBlock* B = schedule.NewBasicBlock();
   BasicBlock* C = schedule.NewBasicBlock();
   BasicBlock* E = schedule.exit();
 
   schedule.AddSuccessor(A, B);
   schedule.AddSuccessor(B, loop1->header());
   schedule.AddSuccessor(loop1->header(), loop2->header());
   schedule.AddSuccessor(loop2->last(), C);
   schedule.AddSuccessor(C, E);
   schedule.AddSuccessor(C, B);
 
   BasicBlockVector* order = scheduler.ComputeSpecialRPO();
 
   CheckLoopContains(loop1->nodes, loop1->count);
 
   CHECK_EQ(schedule.BasicBlockCount(), static_cast<int>(order->size()));
   CheckLoopContains(loop1->nodes, loop1->count);
   CheckLoopContains(loop2->nodes, loop2->count);
 
   BasicBlock* loop3[] = {B, loop1->nodes[0], loop2->nodes[0], C};
   CheckLoopContains(loop3, 4);
-  delete loop1;
-  delete loop2;
 }
 
 
 TEST(RPOLoopBackedges1) {
   HandleAndZoneScope scope;
 
   int size = 8;
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < size; j++) {
       Schedule schedule(scope.main_zone());
       Scheduler scheduler(scope.main_zone(), NULL, &schedule);
       BasicBlock* A = schedule.entry();
       BasicBlock* E = schedule.exit();
 
-      TestLoop* loop1 = CreateLoop(&schedule, size);
+      SmartPointer<TestLoop> loop1(CreateLoop(&schedule, size));
       schedule.AddSuccessor(A, loop1->header());
       schedule.AddSuccessor(loop1->last(), E);
 
       schedule.AddSuccessor(loop1->nodes[i], loop1->header());
       schedule.AddSuccessor(loop1->nodes[j], E);
 
       BasicBlockVector* order = scheduler.ComputeSpecialRPO();
       CheckRPONumbers(order, schedule.BasicBlockCount(), true);
       CheckLoopContains(loop1->nodes, loop1->count);
-      delete loop1;
     }
   }
 }
 
 
 TEST(RPOLoopOutedges1) {
   HandleAndZoneScope scope;
 
   int size = 8;
   for (int i = 0; i < size; i++) {
     for (int j = 0; j < size; j++) {
       Schedule schedule(scope.main_zone());
       Scheduler scheduler(scope.main_zone(), NULL, &schedule);
       BasicBlock* A = schedule.entry();
       BasicBlock* D = schedule.NewBasicBlock();
       BasicBlock* E = schedule.exit();
 
-      TestLoop* loop1 = CreateLoop(&schedule, size);
+      SmartPointer<TestLoop> loop1(CreateLoop(&schedule, size));
       schedule.AddSuccessor(A, loop1->header());
       schedule.AddSuccessor(loop1->last(), E);
 
       schedule.AddSuccessor(loop1->nodes[i], loop1->header());
       schedule.AddSuccessor(loop1->nodes[j], D);
       schedule.AddSuccessor(D, E);
 
       BasicBlockVector* order = scheduler.ComputeSpecialRPO();
       CheckRPONumbers(order, schedule.BasicBlockCount(), true);
       CheckLoopContains(loop1->nodes, loop1->count);
-      delete loop1;
     }
   }
 }
 
 
 TEST(RPOLoopOutedges2) {
   HandleAndZoneScope scope;
 
   int size = 8;
   for (int i = 0; i < size; i++) {
     Schedule schedule(scope.main_zone());
     Scheduler scheduler(scope.main_zone(), NULL, &schedule);
     BasicBlock* A = schedule.entry();
     BasicBlock* E = schedule.exit();
 
-    TestLoop* loop1 = CreateLoop(&schedule, size);
+    SmartPointer<TestLoop> loop1(CreateLoop(&schedule, size));
     schedule.AddSuccessor(A, loop1->header());
     schedule.AddSuccessor(loop1->last(), E);
 
     for (int j = 0; j < size; j++) {
       BasicBlock* O = schedule.NewBasicBlock();
       schedule.AddSuccessor(loop1->nodes[j], O);
       schedule.AddSuccessor(O, E);
     }
 
     BasicBlockVector* order = scheduler.ComputeSpecialRPO();
     CheckRPONumbers(order, schedule.BasicBlockCount(), true);
     CheckLoopContains(loop1->nodes, loop1->count);
-    delete loop1;
   }
 }
 
 
 TEST(RPOLoopOutloops1) {
   HandleAndZoneScope scope;
 
   int size = 8;
   for (int i = 0; i < size; i++) {
     Schedule schedule(scope.main_zone());
     Scheduler scheduler(scope.main_zone(), NULL, &schedule);
     BasicBlock* A = schedule.entry();
     BasicBlock* E = schedule.exit();
-    TestLoop* loop1 = CreateLoop(&schedule, size);
+    SmartPointer<TestLoop> loop1(CreateLoop(&schedule, size));
     schedule.AddSuccessor(A, loop1->header());
     schedule.AddSuccessor(loop1->last(), E);
 
     TestLoop** loopN = new TestLoop* [size];
     for (int j = 0; j < size; j++) {
       loopN[j] = CreateLoop(&schedule, 2);
       schedule.AddSuccessor(loop1->nodes[j], loopN[j]->header());
       schedule.AddSuccessor(loopN[j]->last(), E);
     }
 
     BasicBlockVector* order = scheduler.ComputeSpecialRPO();
     CheckRPONumbers(order, schedule.BasicBlockCount(), true);
     CheckLoopContains(loop1->nodes, loop1->count);
 
     for (int j = 0; j < size; j++) {
       CheckLoopContains(loopN[j]->nodes, loopN[j]->count);
       delete loopN[j];
     }
     delete[] loopN;
-    delete loop1;
   }
 }
 
 
 TEST(RPOLoopMultibackedge) {
   HandleAndZoneScope scope;
   Schedule schedule(scope.main_zone());
   Scheduler scheduler(scope.main_zone(), NULL, &schedule);
 
   BasicBlock* A = schedule.entry();
@@ skipping 1236 matching lines @@
   // The lazy deopt block is deferred.
   CHECK(deopt_block->deferred_);
   CHECK(!call_block->deferred_);
   CHECK(!cont_block->deferred_);
   // The lazy deopt block contains framestate + bailout (and nothing else).
   CHECK_EQ(deoptimization_node, deopt_block->control_input_);
   CHECK_EQ(2, static_cast<int>(deopt_block->nodes_.size()));
   CHECK_EQ(lazy_deopt_node, deopt_block->nodes_[0]);
   CHECK_EQ(state_node, deopt_block->nodes_[1]);
 }