Issue 430103002: Version 3.26.31.12 (merged r22616, r22617)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430103002: Version 3.26.31.12 (merged r22616, r22617) (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.26

Visibility:
Public.

More Reviews

Description

Version 3.26.31.12 (merged r22616, r22617) In GrowMode, force the value to the right representation to avoid deopts between storing the length and storing the value. Smi arrays are only guaranteed to be initialized in non-holey case BUG=16459193 LOG=y R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22739

Patch Set 1 #

Patch Set 2 : Adding test #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -35 lines)			Patch
M	src/hydrogen.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		3 chunks	+18 lines, -23 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-grow-deopt.js	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 4 months ago (2014-07-31 08:54:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22739 (tree was closed).

Expand Messages | Collapse Messages