Fix crash in DOMUIContents::RenderViewCreated

Added null-check for current DOMUI.

BUG=8546
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11322

[pfeldman, 2009-03-10 12:08:53]

LGTM

[Søren Thygesen Gjesse, 2009-03-10 12:12:00]

I am not familiar with this part of Chrome, but what does a NULL content_ui_
mean? Is it a "valid" state?

On 2009/03/10 11:57:13, yurys wrote:
>

[yurys, 2009-03-10 12:27:16]

current_ui_ is a delagate that depends on current content type rendered in
DOMUIContents. It's NULL until a navigation request. My understanding was that
it was expected to be intialized by the time RenderViewCreated is called. It was
a wrong assumption as e.g. InitCurrentUI may fail to find matching DOMUI for a
URL and set current_ui_ to NULL while render view will be created and cause
DOMUIContents::RenderViewCreated execution. 

On 2009/03/10 12:12:00, Søren Gjesse wrote:
> I am not familiar with this part of Chrome, but what does a NULL content_ui_
> mean? Is it a "valid" state?
> 
> On 2009/03/10 11:57:13, yurys wrote:
> >

[yurys, 2009-03-10 12:43:48]

Brett, Glen:
From the stack trace I can see that DOMUIHost content type is about to replace
DOMUIcontents at the moment DOMUIcontents::RenderViewCreated is called. 

It seems wrong to me that previous instance of WebContents(DOMUIContents) is
notified about creation of render view that is going to be used to render
content for the new WebContents instance(DOMUIHost).

On 2009/03/10 12:27:16, yurys wrote:
> current_ui_ is a delagate that depends on current content type rendered in
> DOMUIContents. It's NULL until a navigation request. My understanding was that
> it was expected to be intialized by the time RenderViewCreated is called. It
was
> a wrong assumption as e.g. InitCurrentUI may fail to find matching DOMUI for a
> URL and set current_ui_ to NULL while render view will be created and cause
> DOMUIContents::RenderViewCreated execution. 
> 
> On 2009/03/10 12:12:00, Søren Gjesse wrote:
> > I am not familiar with this part of Chrome, but what does a NULL content_ui_
> > mean? Is it a "valid" state?
> > 
> > On 2009/03/10 11:57:13, yurys wrote:
> > >

[Glen Murphy, 2009-03-10 22:11:11]

Patch LGTM, though I can't comment on the root cause.


On 2009/03/10 12:43:48, Yury Semikhatsky wrote:
> Brett, Glen:
> From the stack trace I can see that DOMUIHost content type is about to replace
> DOMUIcontents at the moment DOMUIcontents::RenderViewCreated is called. 
> 
> It seems wrong to me that previous instance of WebContents(DOMUIContents) is
> notified about creation of render view that is going to be used to render
> content for the new WebContents instance(DOMUIHost).
> 
> On 2009/03/10 12:27:16, yurys wrote:
> > current_ui_ is a delagate that depends on current content type rendered in
> > DOMUIContents. It's NULL until a navigation request. My understanding was
that
> > it was expected to be intialized by the time RenderViewCreated is called. It
> was
> > a wrong assumption as e.g. InitCurrentUI may fail to find matching DOMUI for
a
> > URL and set current_ui_ to NULL while render view will be created and cause
> > DOMUIContents::RenderViewCreated execution. 
> > 
> > On 2009/03/10 12:12:00, Søren Gjesse wrote:
> > > I am not familiar with this part of Chrome, but what does a NULL
content_ui_
> > > mean? Is it a "valid" state?
> > > 
> > > On 2009/03/10 11:57:13, yurys wrote:
> > > >