Issue 43009: Context menus only opens if the mouse are released in the same view as it was...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43009: Context menus only opens if the mouse are released in the same view as it was... (Closed)

Created:
11 years, 9 months ago by Xharze

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Ben Goodger (Google), sky

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Context menus only opens if the mouse are released in the same view as it was pressed. BUG=7259

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/views/view.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/43009/diff/1/2 File chrome/views/view.cc (right): http://codereview.chromium.org/43009/diff/1/2#newcode501 Line 501: ConvertPointToView(this, this, &location); I don't think you need ...

11 years, 9 months ago (2009-03-10 16:51:14 UTC) #2

Xharze

You were absolutely right in you review comments. Those lines were not needed, and have ...

11 years, 9 months ago (2009-03-12 23:48:05 UTC) #3

Xharze

11 years, 9 months ago (2009-03-18 11:32:17 UTC) #5

If there arn't any further comments, could you please commit the patch set?

Expand Messages | Collapse Messages

Issue 43009: Context menus only opens if the mouse are released in the same view as it was... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages