Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 430083002: Use a qualified path to blink resources, content part. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
brettw, eseidel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Use a qualified path to blink resources, content part. This should prevent problems such as described in [chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compile errors in blink_platform_impl.cc Depends on https://codereview.chromium.org/431883002 BUG=400860 TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288077

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 2 chunks +7 lines, -1 line 0 comments Download
M content/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
eseidel
lgtm too, but I don't think I have power here.
6 years, 4 months ago (2014-08-07 01:41:50 UTC) #1
eseidel
It looks like brettw is probably your correct reviewer: https://chromium.googlesource.com/chromium/src/+/master/content/OWNERS
6 years, 4 months ago (2014-08-07 01:43:38 UTC) #2
eseidel
Going to TBR=brettw in hopes of stopping the bleeding quicker. Bots are still failing 14 ...
6 years, 4 months ago (2014-08-07 01:51:41 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-07 01:52:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/430083002/20001
6 years, 4 months ago (2014-08-07 01:53:50 UTC) #5
Nico
eseidel: This won't work yet. The gn bot needs my blink change which went in ...
6 years, 4 months ago (2014-08-07 03:07:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 07:10:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 09:10:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/3558)
6 years, 4 months ago (2014-08-07 09:10:01 UTC) #9
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-07 15:10:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/430083002/20001
6 years, 4 months ago (2014-08-07 15:10:59 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:35:07 UTC) #12
Message was sent while issue was closed.
Change committed as 288077

Powered by Google App Engine
This is Rietveld 408576698