Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 430013002: Increase shutdown timeout to work around slow analysis server startup time. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Slightly shorter timeout Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index 4233704b9a21e53439456f840f1b596c17b13616..59c3f321a5f32be02fd6c197d3bb1aebbc83dbca 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -20,8 +20,14 @@ abstract class AbstractAnalysisServerIntegrationTest {
/**
* Amount of time to give the server to respond to a shutdown request before
* forcibly terminating it.
+ *
+ * TODO(paulberry): the extra-long timeout (20s) is because sometimes the
+ * buildbots are slow to spawn a new analysis server process. It would be
+ * better to wait for the initial "server.connected" message with a long
+ * timeout, and keep this timeout short.
+ *
*/
- static const Duration SHUTDOWN_TIMEOUT = const Duration(seconds: 5);
+ static const Duration SHUTDOWN_TIMEOUT = const Duration(seconds: 20);
/**
* Connection to the analysis server.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698