Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 430003003: Add UUID, strlcpy, and their tests to util (Closed)

Created:
6 years, 4 months ago by Mark Mentovai
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add UUID, c16lcpy (strlcpy for char16*), and their tests to util. These are dependencies of the upcoming MinidumpStringWriter. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4d6b867a1fbd

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address review comments #

Total comments: 2

Patch Set 3 : For commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -0 lines) Patch
A util/misc/uuid.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A util/misc/uuid.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download
A util/misc/uuid_test.cc View 1 1 chunk +78 lines, -0 lines 0 comments Download
A util/stdlib/cxx.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A util/stdlib/strlcpy.h View 1 chunk +52 lines, -0 lines 0 comments Download
A util/stdlib/strlcpy.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A util/stdlib/strlcpy_test.cc View 1 chunk +90 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
6 years, 4 months ago (2014-08-01 16:58:15 UTC) #1
Robert Sesek
https://codereview.chromium.org/430003003/diff/1/util/misc/uuid.h File util/misc/uuid.h (right): https://codereview.chromium.org/430003003/diff/1/util/misc/uuid.h#newcode28 util/misc/uuid.h:28: struct UUID { No default constructor to zero-initialize everything? ...
6 years, 4 months ago (2014-08-01 17:28:18 UTC) #2
Mark Mentovai
https://codereview.chromium.org/430003003/diff/1/util/misc/uuid.h File util/misc/uuid.h (right): https://codereview.chromium.org/430003003/diff/1/util/misc/uuid.h#newcode28 util/misc/uuid.h:28: struct UUID { rsesek wrote: > No default constructor ...
6 years, 4 months ago (2014-08-01 18:05:49 UTC) #3
Robert Sesek
LGTM https://codereview.chromium.org/430003003/diff/20001/util/misc/uuid.cc File util/misc/uuid.cc (right): https://codereview.chromium.org/430003003/diff/20001/util/misc/uuid.cc#newcode30 util/misc/uuid.cc:30: COMPILE_ASSERT(std::is_standard_layout<UUID>::value, Faaaancy. https://codereview.chromium.org/430003003/diff/20001/util/misc/uuid.h File util/misc/uuid.h (right): https://codereview.chromium.org/430003003/diff/20001/util/misc/uuid.h#newcode43 util/misc/uuid.h:43: ...
6 years, 4 months ago (2014-08-01 18:37:03 UTC) #4
Mark Mentovai
6 years, 4 months ago (2014-08-01 18:39:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 4d6b867a1fbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698