src/IceInstX8632.cpp - Issue 429993002: Subzero: Try to fix warnings and errors in the Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8632.cpp

Issue 429993002: Subzero: Try to fix warnings and errors in the Windows build. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Forward-declare latest set of emit() template specializations Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8632.cpp

diff --git a/src/IceInstX8632.cpp b/src/IceInstX8632.cpp

index be84554543a864243a9ec1f039395b74714d3e1d..14e95031d8d7b20f85dcaafeef226786e31143fb 100644

--- a/src/IceInstX8632.cpp

+++ b/src/IceInstX8632.cpp

@@ -640,6 +640,7 @@ template <> void InstX8632Imul::emit(const Cfg *Func) const {

if (getDest()->getType() == IceType_i8) {

// The 8-bit version of imul only allows the form "imul r/m8".

Variable *Src0 = llvm::dyn_cast<Variable>(getSrc(0));

+ (void)Src0;

assert(Src0 && Src0->getRegNum() == TargetX8632::Reg_eax);

Str << "\timul\t";

getSrc(1)->emit(Func);

@@ -686,6 +687,7 @@ void InstX8632Shld::emit(const Cfg *Func) const {

getSrc(1)->emit(Func);

Str << ", ";

if (Variable *ShiftReg = llvm::dyn_cast<Variable>(getSrc(2))) {

+ (void)ShiftReg;

assert(ShiftReg->getRegNum() == TargetX8632::Reg_ecx);

Str << "cl";

} else {

@@ -711,6 +713,7 @@ void InstX8632Shrd::emit(const Cfg *Func) const {

getSrc(1)->emit(Func);

Str << ", ";

if (Variable *ShiftReg = llvm::dyn_cast<Variable>(getSrc(2))) {

+ (void)ShiftReg;

assert(ShiftReg->getRegNum() == TargetX8632::Reg_ecx);

Str << "cl";

} else {

« no previous file with comments | « src/IceInstX8632.h ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »