Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: src/IceInstX8632.h

Issue 429993002: Subzero: Try to fix warnings and errors in the Windows build. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceInstX8632.cpp » ('j') | src/IceTargetLoweringX8632.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstX8632.h
diff --git a/src/IceInstX8632.h b/src/IceInstX8632.h
index ddea6b581c254dbfa0e9bbfceb398e834f01cbd9..65e01d8bf5091b880e585d3abf44a34afa6a7232 100644
--- a/src/IceInstX8632.h
+++ b/src/IceInstX8632.h
@@ -1183,6 +1183,29 @@ private:
virtual ~InstX8632Xchg() {}
};
+// Declare partial template specializations of emit() methods that
+// already have default implementations. Without this, there is the
+// possibility of ODR violations and link errors.
+template <> void InstX8632Addss::emit(const Cfg *Func) const;
+template <> void InstX8632Div::emit(const Cfg *Func) const;
+template <> void InstX8632Divss::emit(const Cfg *Func) const;
+template <> void InstX8632Idiv::emit(const Cfg *Func) const;
+template <> void InstX8632Imul::emit(const Cfg *Func) const;
+template <> void InstX8632Lea::emit(const Cfg *Func) const;
+template <> void InstX8632Mulss::emit(const Cfg *Func) const;
+template <> void InstX8632Padd::emit(const Cfg *Func) const;
+template <> void InstX8632Pcmpeq::emit(const Cfg *Func) const;
+template <> void InstX8632Pcmpgt::emit(const Cfg *Func) const;
+template <> void InstX8632Pextrw::emit(const Cfg *Func) const;
+template <> void InstX8632Pinsrw::emit(const Cfg *Func) const;
+template <> void InstX8632Pmullw::emit(const Cfg *Func) const;
+template <> void InstX8632Pmuludq::emit(const Cfg *Func) const;
+template <> void InstX8632Psll::emit(const Cfg *Func) const;
+template <> void InstX8632Psra::emit(const Cfg *Func) const;
+template <> void InstX8632Psub::emit(const Cfg *Func) const;
+template <> void InstX8632Sqrtss::emit(const Cfg *Func) const;
+template <> void InstX8632Subss::emit(const Cfg *Func) const;
wala 2014/07/30 19:51:00 InstX8632Pblendvb, InstX8632Blendvps, InstX8632Pin
Jim Stichnoth 2014/07/30 21:45:11 Thanks. There were a couple of class name changes
+
} // end of namespace Ice
#endif // SUBZERO_SRC_ICEINSTX8632_H
« no previous file with comments | « no previous file | src/IceInstX8632.cpp » ('j') | src/IceTargetLoweringX8632.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698