Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 429903004: Another attempt to make Visual C++ happy. (Closed)

Created:
6 years, 4 months ago by Jarin
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Another attempt to make Visual C++ happy. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22717

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add another void* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/instruction.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
6 years, 4 months ago (2014-07-30 15:02:31 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/429903004/diff/1/src/compiler/instruction.h File src/compiler/instruction.h (right): https://codereview.chromium.org/429903004/diff/1/src/compiler/instruction.h#newcode492 src/compiler/instruction.h:492: void operator delete(void* location) { UNREACHABLE(); ...
6 years, 4 months ago (2014-07-30 15:03:32 UTC) #2
Jarin
On 2014/07/30 15:03:32, Jakob wrote: > LGTM with comment. > > https://codereview.chromium.org/429903004/diff/1/src/compiler/instruction.h > File src/compiler/instruction.h ...
6 years, 4 months ago (2014-07-30 15:06:14 UTC) #3
Jarin
6 years, 4 months ago (2014-07-30 15:06:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22717 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698