DevTools: add pie chart to the paint profiler overview.

DevTools: add pie chart to the paint profiler overview.
drive-by bugfixes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179254

[caseq, 2014-07-30 15:15:07]

lgtm

[pfeldman, 2014-07-30 15:30:26]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-30 15:31:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/429883004/1

[commit-bot: I haz the power, 2014-07-30 15:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 15:31:32]

Failed to apply patch for Source/devtools/front_end/ui/PieChart.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/ui/PieChart.js
  Hunk #1 succeeded at 30 with fuzz 2.
  Hunk #2 FAILED at 48.
  Hunk #3 succeeded at 101 (offset 2 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/ui/PieChart.js.rej

Patch:       Source/devtools/front_end/ui/PieChart.js
Index: Source/devtools/front_end/ui/PieChart.js
diff --git a/Source/devtools/front_end/ui/PieChart.js
b/Source/devtools/front_end/ui/PieChart.js
index
8cacabdd920d63af6f36ead6b788871105823702..f49d55374a8358125c997a9f56ee016a8fc89f13
100644
--- a/Source/devtools/front_end/ui/PieChart.js
+++ b/Source/devtools/front_end/ui/PieChart.js
@@ -30,10 +30,10 @@
 
 /**
  * @constructor
- * @param {number=} totalValue
+ * @param {number} size
  * @param {function(number):string=} formatter
  */
-WebInspector.PieChart = function(totalValue, formatter)
+WebInspector.PieChart = function(size, formatter)
 {
     const shadowOffset = 0.04;
     this.element = document.createElementWithClass("div", "pie-chart");
@@ -48,29 +48,35 @@ WebInspector.PieChart = function(totalValue, formatter)
     var background = this._createSVGChild(this._group, "circle");
     background.setAttribute("r", 1);
     background.setAttribute("fill", "hsl(0,0%,92%)");
-    if (totalValue) {
-        var totalString = formatter ? formatter(totalValue) : totalValue;
-        this._totalElement = this.element.createChild("div",
"pie-chart-foreground");
-        this._totalElement.textContent = totalString;
-        this._totalValue = totalValue;
-    }
+    this._totalElement = this.element.createChild("div",
"pie-chart-foreground");
+    this._formatter = formatter;
+    this._slices = [];
     this._lastAngle = -Math.PI/2;
-    this.setSize(100);
+    this._setSize(size);
 }
 
 WebInspector.PieChart.prototype = {
     /**
-     * @param {number} value
+     * @param {number} totalValue
      */
-    setTotal: function(value)
+    setTotal: function(totalValue)
     {
-        this._totalValue = value;
+        for (var i = 0; i < this._slices.length; ++i)
+            this._slices[i].remove();
+        this._slices = [];
+        this._totalValue = totalValue;
+        var totalString;
+        if (totalValue)
+            totalString = this._formatter ? this._formatter(totalValue) :
totalValue;
+        else
+            totalString = "";
+        this._totalElement.textContent = totalString;
     },
 
     /**
      * @param {number} value
      */
-    setSize: function(value)
+    _setSize: function(value)
     {
         this._group.setAttribute("transform", "scale(" + (value / 2) + ")
translate(1,1)");
         var size = value + "px";
@@ -99,6 +105,7 @@ WebInspector.PieChart.prototype = {
         var largeArc = sliceAngle > Math.PI ? 1 : 0;
         path.setAttribute("d", "M0,0 L" + x1 + "," + y1 + " A1,1,0," + largeArc
+ ",1," + x2 + "," + y2 + " Z");
         path.setAttribute("fill", color);
+        this._slices.push(path);
     },
 
     /**

[pfeldman, 2014-07-30 20:25:11]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-30 20:26:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/429883004/40001

[commit-bot: I haz the power, 2014-07-30 21:32:08]

Change committed as 179254