Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: Source/bindings/core/v8/generated.gyp

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: GYP Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/generated.gyp
diff --git a/Source/bindings/core/v8/generated.gyp b/Source/bindings/core/v8/generated.gyp
index 6a61c2e7a4da4a21776f49251ab2f938061acb4a..aa45f6706a3dee1a1a1aa97007cd9de388dc6747 100644
--- a/Source/bindings/core/v8/generated.gyp
+++ b/Source/bindings/core/v8/generated.gyp
@@ -122,12 +122,62 @@
},
################################################################################
{
+ # http://crbug.com/358074
+ # See comments on 'bindings_core_v8_generated_individual' target
+ 'target_name': 'bindings_core_dictionary_impl_generated',
+ 'type': 'none',
+ 'hard_dependency': 1,
+ 'dependencies': [
+ '<(bindings_scripts_dir)/scripts.gyp:cached_jinja_templates',
+ '<(bindings_scripts_dir)/scripts.gyp:cached_lex_yacc_tables',
+ '../../modules/generated.gyp:interfaces_info',
+ ],
+ 'sources': [
+ '<@(core_dictionary_idl_files)',
+ ],
+ 'rules': [{
+ 'rule_name': 'idl_dictionary',
+ 'extension': 'idl',
+ 'msvs_external_rule': 1,
+ 'inputs': [
+ '<@(idl_lexer_parser_files)',
+ '<@(idl_compiler_files)',
+ '<(bindings_scripts_output_dir)/lextab.py',
+ '<(bindings_scripts_output_dir)/parsetab.pickle',
+ '<(bindings_scripts_output_dir)/cached_jinja_templates.stamp',
+ '<(bindings_dir)/IDLExtendedAttributes.txt',
+ '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+ ],
+ 'outputs': [
+ '<@(generated_core_dictionary_files)',
+ ],
+ 'action': [
+ 'python',
+ '-S', # skip 'import site' to speed up startup
bashi 2014/08/05 05:36:22 Removed -S because this action runs once.
+ '<(bindings_scripts_dir)/idl_compiler.py',
+ '--cache-dir',
+ '<(bindings_scripts_output_dir)',
+ '--output-dir',
+ '<(SHARED_INTERMEDIATE_DIR)/blink/',
+ '--interfaces-info',
+ '<(bindings_modules_output_dir)/InterfacesInfoModules.pickle',
+ '--write-file-only-if-changed',
+ '<(write_file_only_if_changed)',
+ '--generate-dictionary-impl',
+ '<(RULE_INPUT_PATH)',
+ ],
+ 'message': 'Generating IDL dictionary impls from <(RULE_INPUT_PATH)',
+ }],
+ },
+################################################################################
+ {
# GN version: //third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated
'target_name': 'bindings_core_v8_generated',
'type': 'none',
'dependencies': [
'bindings_core_v8_generated_aggregate',
'bindings_core_v8_generated_individual',
+ 'bindings_core_dictionary_impl_generated',
],
},
################################################################################

Powered by Google App Engine
This is Rietveld 408576698