Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/scripts/aggregate_generated_bindings.py

Issue 429853002: IDL: Add build target for IDL dictionary impl generation in core (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/v8/generated.gyp ('k') | Source/bindings/scripts/code_generator_v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/aggregate_generated_bindings.py
diff --git a/Source/bindings/scripts/aggregate_generated_bindings.py b/Source/bindings/scripts/aggregate_generated_bindings.py
index acfa72c681fe45575df5cf04b4b50bd9841b3ac3..5efb42c9ea0edd46e2750bf8e03aa6655672e3ae 100755
--- a/Source/bindings/scripts/aggregate_generated_bindings.py
+++ b/Source/bindings/scripts/aggregate_generated_bindings.py
@@ -51,10 +51,9 @@ Design doc: http://www.chromium.org/developers/design-documents/idl-build
import errno
import os
import re
-import subprocess
import sys
-from utilities import idl_filename_to_interface_name
+from utilities import idl_filename_to_interface_name, read_idl_files_list_from_file
# A regexp for finding Conditional attributes in interface definitions.
CONDITIONAL_PATTERN = re.compile(
@@ -171,21 +170,6 @@ def write_content(content, output_file_name):
f.write(content)
-def resolve_cygpath(cygdrive_names):
- if not cygdrive_names:
- return []
- cmd = ['cygpath', '-f', '-', '-wa']
- process = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
- idl_file_names = []
- for file_name in cygdrive_names:
- process.stdin.write('%s\n' % file_name)
- process.stdin.flush()
- idl_file_names.append(process.stdout.readline().rstrip())
- process.stdin.close()
- process.wait()
- return idl_file_names
-
-
def main(args):
if len(args) <= 4:
raise Exception('Expected at least 5 arguments.')
@@ -194,15 +178,7 @@ def main(args):
in_out_break_index = args.index('--')
output_file_names = args[in_out_break_index + 1:]
- with open(input_file_name) as input_file:
- file_names = sorted([os.path.realpath(line.rstrip('\n'))
- for line in input_file])
- idl_file_names = [file_name for file_name in file_names
- if not file_name.startswith('/cygdrive')]
- cygdrive_names = [file_name for file_name in file_names
- if file_name.startswith('/cygdrive')]
- idl_file_names.extend(resolve_cygpath(cygdrive_names))
-
+ idl_file_names = read_idl_files_list_from_file(input_file_name)
files_meta_data = extract_meta_data(idl_file_names)
total_partitions = len(output_file_names)
for partition, file_name in enumerate(output_file_names):
« no previous file with comments | « Source/bindings/modules/v8/generated.gyp ('k') | Source/bindings/scripts/code_generator_v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698